KEMBAR78
Make `_LIBCPP_VERSION` check independent from `DOCTEST_CLANG` by Saalvage · Pull Request #709 · doctest/doctest · GitHub
Skip to content

Make _LIBCPP_VERSION check independent from DOCTEST_CLANG #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2022
Merged

Make _LIBCPP_VERSION check independent from DOCTEST_CLANG #709

merged 2 commits into from
Dec 17, 2022

Conversation

Saalvage
Copy link
Member

@Saalvage Saalvage commented Oct 7, 2022 •
edited
Loading

Fixes #672

TODO:

  • libc++ & gcc CI

@Saalvage Saalvage linked an issue Oct 7, 2022 that may be closed by this pull request
libc++ with gcc broken #672
Closed
@Saalvage Saalvage mentioned this pull request Oct 7, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 7, 2022 •
edited
Loading

Codecov Report

Merging #709 (ce17adc) into dev (4e38208) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #709   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files           2        2           
  Lines        2127     2127           
=======================================
  Hits         1961     1961           
  Misses        166      166
Impacted Files Coverage Δ
doctest/parts/doctest_fwd.h 97.70% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Saalvage Saalvage mentioned this pull request Dec 17, 2022
Open
5 tasks
@Saalvage Saalvage merged commit 805e619 into dev Dec 17, 2022
@Saalvage Saalvage deleted the fix-672 branch December 17, 2022 00:38
onqtam pushed a commit that referenced this pull request Feb 27, 2023
@Saalvage @onqtam
Make _LIBCPP_VERSION check independent from DOCTEST_CLANG (#709)
33f0aa2 
* Make `_LIBCPP_VERSION` check independent from `DOCTEST_CLANG`

* Update doctest.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

libc++ with gcc broken

1 participant

@Saalvage