KEMBAR78
IncorrectDelimiterChecker: Replace &'static str with &'a str (#187) by DDtKey · Pull Request #191 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

@DDtKey
Copy link
Member

@DDtKey DDtKey commented May 16, 2020

Fix for #187:
Replaced &'static str with &'a str for IncorrectDelimiterChecker.

@mgrachev
Copy link
Member

mgrachev commented May 16, 2020

@DDtKey 👋Thank you for your contribution! 🚀

Please, add your PR to the CHANGELOG.md file.

Add #191 to changelog
@DDtKey
Copy link
Member Author

DDtKey commented May 16, 2020

@mgrachev updated changelog. I'm glad to contribute.

@mstruebing
Copy link
Member

Could someone explain to me what <'a> and <'_> exactly mean?
I assume something about the lifetime but I'm not really sure.

@mgrachev
Copy link
Member

Could someone explain to me what <'a> and <'_> exactly mean?
I assume something about the lifetime but I'm not really sure.

These are lifetimes of referencing:
<'a> - explicit lifetime;
<'_> - anonymous lifetime;

More information there: https://doc.rust-lang.org/book/ch10-03-lifetime-syntax.html#lifetime-annotation-syntax

@mgrachev mgrachev merged commit 2503af2 into dotenv-linter:master May 16, 2020
@mgrachev
Copy link
Member

@DDtKey Thank you! 👍

If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

@DDtKey
Copy link
Member Author

DDtKey commented May 16, 2020

@DDtKey Thank you! 👍

If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

Of course 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants