KEMBAR78
Add default exclude list by ametalon · Pull Request #324 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add default exclude list #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2020
Merged

Add default exclude list #324

merged 3 commits into from
Oct 20, 2020

Conversation

ametalon
Copy link
Contributor

@ametalon ametalon commented Oct 17, 2020 •
edited
Loading

First stab at #323
This implementation hard-excludes files and there is no way to run checks on them.
Even running the linter with these files listed explicitly will still skip them.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@ametalon
first stab at dotenv-linter#323
7f6ac4d 
This implementation hard-excludes files and there is no way to run checks on them.
Even running the linter with these files listed explicitly will still skip them.
@ametalon ametalon changed the title first stab at #323 Add default exclude list Oct 17, 2020
@codecov-io
Copy link

codecov-io commented Oct 17, 2020 •
edited
Loading

Codecov Report

Merging #324 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   96.98%   96.99%           
=======================================
  Files          32       32           
  Lines        2292     2294    +2     
=======================================
+ Hits         2223     2225    +2     
  Misses         69       69
Impacted Files Coverage Δ
src/common/file_entry.rs 98.64% <100.00%> (+0.03%) ⬆️
src/lib.rs 98.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6adeec...8dec021. Read the comment docs.

mstruebing
mstruebing reviewed Oct 18, 2020
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice PR, could you add your change to the CHANGELOG.md file and maybe write a setence in the documentation/readme about it please?

@ametalon
Copy link
Contributor Author

Sure, just wanted to make sure that you ok with the approach I took.
Readme doesn't mention exclusion option at all and redirects to the docs for more info.
Should I copy paragraph from the docs or leave readme as is?
I'm failing to see how I can add stuff to the docs, could you give me directions?

@mstruebing
Copy link
Member

Readme doesn't mention exclusion option at all and redirects to the docs for more info.

Sorry, my bad, just leave it as it is :)

mgrachev
mgrachev reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ametalon 👋 Thank you for your contribution! 🚀

I have left a comment. Please look a look 👀

@mgrachev
Copy link
Member

mgrachev commented Oct 19, 2020 •
edited
Loading

Sure, just wanted to make sure that you ok with the approach I took.
Readme doesn't mention exclusion option at all and redirects to the docs for more info.
Should I copy paragraph from the docs or leave readme as is?
I'm failing to see how I can add stuff to the docs, could you give me directions?

All documentation lives here: https://github.com/dotenv-linter/dotenv-linter.github.io.
Please add information about these changes to this page https://github.com/dotenv-linter/dotenv-linter.github.io/blob/master/docs/usage.md (at the bottom of the page).

ametalon added a commit to ametalon/dotenv-linter.github.io that referenced this pull request Oct 19, 2020
@ametalon
Mention default exclusion list
24c0290 
Document changes from dotenv-linter/dotenv-linter#324
@ametalon ametalon mentioned this pull request Oct 19, 2020
Merged
@mgrachev mgrachev linked an issue Oct 20, 2020 that may be closed by this pull request
Invalid linting on .envrc (direnv) files #323
Closed
@mgrachev mgrachev added this to the v2.2.1 milestone Oct 20, 2020
mgrachev
mgrachev reviewed Oct 20, 2020
View reviewed changes
@mgrachev mgrachev merged commit f48e402 into dotenv-linter:master Oct 20, 2020
@mgrachev
Copy link
Member

@ametalon Thank you for your help! 🚀

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

mgrachev added a commit to dotenv-linter/dotenv-linter.github.io that referenced this pull request Oct 24, 2020
@ametalon @mgrachev
Mention default exclusion list (#9)
ac93d75 
* Mention default exclusion list

Document changes from dotenv-linter/dotenv-linter#324

* Update docs/usage.md

Co-authored-by: Grachev Mikhail <work@mgrachev.com>

Co-authored-by: Grachev Mikhail <work@mgrachev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstruebing mstruebing mstruebing left review comments

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v2.2.1

Development

Successfully merging this pull request may close these issues.

Invalid linting on .envrc (direnv) files

4 participants

@ametalon @codecov-io @mstruebing @mgrachev