Get rid of String::from when creating LineEntry #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to get rid of some `.to_string()` calls.
miDeb
force-pushed
the
line_entry_new_into_string
branch
from
fde4b3a to
cd47f12
Compare
|
Seems like this is ready to merge, the only issue pointed out by Actions is solved with #405 |
mgrachev
approved these changes
Mar 27, 2021
|
@miDeb Great work 👍 Thank you ❤️ |
Ru5ty0ne
pushed a commit
to Ru5ty0ne/dotenv-linter
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #403.
✔ Checklist: