Don't fix key order for substitution variables (#383) #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still TODO: - add comment to line
stygian-coffee
force-pushed
the
key-order-substitution-variable
branch
from
7b75536 to
c15abcc
Compare
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 95.73% 99.20% +3.47%
==========================================
Files 37 37
Lines 2531 2643 +112
==========================================
+ Hits 2423 2622 +199
+ Misses 108 21 -87
Continue to review full report at Codecov.
|
stygian-coffee
force-pushed
the
key-order-substitution-variable
branch
from
c15abcc to
a78522c
Compare
mgrachev
reviewed
Mar 30, 2021
There was a problem hiding this comment.
@stygian-coffee 👋 Thank you for your contribution 🚀
I have left a comment. Please take a look at it 👀
stygian-coffee
force-pushed
the
key-order-substitution-variable
branch
from
29cda83 to
ba03ca2
Compare
DDtKey
reviewed
Mar 31, 2021
There was a problem hiding this comment.
Thank you for your contribution! 🚀
I left some comments, please take a look.
Also add this PR to CHANGELOG.md please 🙂
Test a substitution variable not in current group, just in case.
mgrachev
reviewed
Apr 2, 2021
Slight difference in functionality because lists of substitution variables no longer include "and".
mgrachev
approved these changes
Apr 3, 2021
|
@stygian-coffee Thank you for your help 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #383.
I think the
fix_warningsfunction could still use a bit of cleanup after my changes, since I do think it nests a bit deep now.✔ Checklist: