KEMBAR78
Check if the amount of predicted checks match the amount of checks done, print warning if not. by marcel-baur · Pull Request #415 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Check if the amount of predicted checks match the amount of checks done, print warning if not. #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 16, 2021
Merged

Check if the amount of predicted checks match the amount of checks done, print warning if not. #415

merged 10 commits into from
Apr 16, 2021

Conversation

@marcel-baur
Copy link
Contributor

@marcel-baur marcel-baur commented Apr 9, 2021 •
edited
Loading

Regards (#409).
Are there any cases where this issue occurs? If so, I could add a test case.

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);

@codecov-io
Copy link

codecov-io commented Apr 9, 2021 •
edited
Loading

Codecov Report

Merging #415 (5b1d71a) into master (5d4e8ed) will decrease coverage by 0.18%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   99.20%   99.01%   -0.19%     
==========================================
  Files          37       37              
  Lines        2632     2641       +9     
==========================================
+ Hits         2611     2615       +4     
- Misses         21       26       +5
Impacted Files Coverage Δ
src/common/output/fix.rs 87.50% <0.00%> (-12.50%) ⬇️
src/lib.rs 98.52% <80.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4e8ed...5b1d71a. Read the comment docs.

@mgrachev mgrachev added this to the v3.1.0 milestone Apr 12, 2021
@mgrachev mgrachev linked an issue Apr 12, 2021 that may be closed by this pull request
Fix the possibility of incorrectly fixing of the ENV file #409
Closed
mgrachev
mgrachev reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcel-baur 👋 Thank you for your contribution 🦀

I have left some comments. Please take a look at them 👀

@mgrachev
Copy link
Member

Also, please do this one ⬇️

  • This PR has been added to CHANGELOG.md (at the top of the list);

And please fix CI - all checks have to be green ✅

Linters / linters / commitlint (pull_request) Failing after 13s — linters / commitlint

marcel-baur added a commit to marcel-baur/dotenv-linter that referenced this pull request Apr 13, 2021
@marcel-baur
feat: add pull request dotenv-linter#415
96b7885
@mgrachev
Copy link
Member

Please do this one ⬇️

  • This PR has been added to CHANGELOG.md (at the top of the list);

@mgrachev mgrachev requested a review from a team April 14, 2021 08:22
@marcel-baur
Copy link
Contributor Author

Please do this one ⬇️

  • This PR has been added to CHANGELOG.md (at the top of the list);

I think I have already done this with a change request, should I do that within this pull request as well?

@mgrachev
Copy link
Member

Please do this one ⬇️

  • This PR has been added to CHANGELOG.md (at the top of the list);

I think I have already done this with a change request, should I do that within this pull request as well?

Yes, please.

DDtKey
DDtKey reviewed Apr 15, 2021
View reviewed changes
DDtKey
DDtKey previously approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👍

As far as I can see, only my comment on the changelog remains. But it's okay I think

@mgrachev mgrachev merged commit 523c20b into dotenv-linter:master Apr 16, 2021
@mgrachev
Copy link
Member

@marcel-baur Thank you for your help 👍

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Fix the possibility of incorrectly fixing of the ENV file

4 participants

@marcel-baur @codecov-io @mgrachev @DDtKey