Refactor Check unit tests #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc1098
force-pushed
the
check_test_macro
branch
from
1d06e83 to
990b095
Compare
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 99.01% 98.97% -0.05%
==========================================
Files 38 38
Lines 2746 2634 -112
==========================================
- Hits 2719 2607 -112
Misses 27 27
Continue to review full report at Codecov.
|
mc1098
force-pushed
the
check_test_macro
branch
from
990b095 to
3d88c8c
Compare
|
I've just updated this PR to take into account the recently merged #414 🎉 |
|
@mc1098 👋 Thank you for your contribution 👍 Sorry, I'm quite busy now, so I'll try to review your PR by the end of the week 🙁 |
added 4 commits
April 20, 2021 21:42
check_tester macro helps to remove the boiler plate when testing the impls of the Check trait.
Internal documentation for the check_tester macro to make it easier to understand and use with some examples.
Refactors SubstitutionKeyChecker unit tests to use the check_tester macro inline with the other Check impls.
mc1098
force-pushed
the
check_test_macro
branch
from
3d88c8c to
5b362f8
Compare
DDtKey
reviewed
Apr 28, 2021
added 2 commits
April 29, 2021 02:29
Replaces the check_tester! declarative macro with a generic test helper function. This will be more explicit and easier to update than the check_tester macro.
DDtKey
previously approved these changes
Apr 29, 2021
2 tasks
mgrachev
previously approved these changes
May 8, 2021
|
@mc1098 Please add your changes to the CHANGELOG.md file 🙂 |
Updates the changelog to include the changes made in the PR dotenv-linter#421.
mgrachev
previously approved these changes
May 8, 2021
Fixes the 'inconsistent-struct-constructor' clippy warning.
mgrachev
approved these changes
May 8, 2021
|
@mc1098 Thank you for your help 🔥 🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the unit tests for Check implementations as per #419.
Unit tests have been replaced with a new check_tester macro which takes care of the boiler plate of writing multiple test cases. This would make the tests easier to change when an interface change is required, such as #410, as only the expanded code of the macro is changed to reflect the new API.
This change would also effect #414 and once that PR is merged I'm happy to make the changes so that it is included in this refactoring :)
Closes #419
✔ Checklist: