KEMBAR78
feat: add support for double quoted multi-line values by DDtKey · Pull Request #453 · dotenv-linter/dotenv-linter · GitHub
Skip to content

feat: add support for double quoted multi-line values #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

feat: add support for double quoted multi-line values #453

merged 2 commits into from
Dec 15, 2021

Conversation

@DDtKey
Copy link
Member

@DDtKey DDtKey commented Dec 12, 2021 •
edited
Loading

Continuing to #450

Closes #442

It seems that we should update documentation. But tech-functionality is ready 🙂

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@DDtKey DDtKey requested a review from a team December 12, 2021 13:34
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021 •
edited
Loading

Codecov Report

Merging #453 (9062aa4) into master (8c7eab3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   98.86%   98.87%   +0.01%     
==========================================
  Files          40       41       +1     
  Lines        2640     2676      +36     
==========================================
+ Hits         2610     2646      +36     
  Misses         30       30
Impacted Files Coverage Δ
src/common.rs 100.00% <ø> (ø)
src/common/quote_type.rs 100.00% <100.00%> (ø)
src/lib.rs 98.34% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7eab3...9062aa4. Read the comment docs.

@github-actions
Copy link

Benchmark for aaa9c3a

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 56.1±4.22µs 55.6±3.00µs +0.90%
dotenv_linter compare 48.7±2.99µs 48.2±3.20µs +1.04%
dotenv_linter fix 206.7±137.04µs 180.0±57.63µs +14.83%
dotenv_linter fix with backup 283.2±203.86µs 249.0±110.31µs +13.73%

@github-actions
Copy link

Benchmark for ce3c307

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 54.7±5.01µs 51.3±3.10µs +6.63%
dotenv_linter compare 45.2±5.80µs 44.4±2.54µs +1.80%
dotenv_linter fix 353.7±540.44µs 194.5±77.06µs +81.85%
dotenv_linter fix with backup 235.5±89.80µs 269.5±213.61µs -12.62%

DDtKey
DDtKey commented Dec 12, 2021
View reviewed changes
@mgrachev mgrachev merged commit 7b990e4 into master Dec 15, 2021
@mgrachev mgrachev deleted the double-quoted-multiline-values branch December 15, 2021 10:54
@DDtKey DDtKey mentioned this pull request Jan 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Real multiple line problem

3 participants

@DDtKey @codecov-commenter @mgrachev