KEMBAR78
fix: don't remove quotes for values containing hash-sign by 95jonpet · Pull Request #560 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

@95jonpet
Copy link
Contributor

@95jonpet 95jonpet commented Oct 4, 2022

Ensure that values containing would-be comments are not altered by stripping quotes.

Refs: #559

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@95jonpet
Copy link
Contributor Author

95jonpet commented Oct 4, 2022

Proposed documentation change: dotenv-linter/dotenv-linter.github.io#55

Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your input! 👍

@DDtKey DDtKey changed the title fix: don't remove quotes around comments fix: don't remove quotes for values containing hash-sign Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #560 (8b12a27) into master (a526a06) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          43       43           
  Lines        2761     2773   +12     
=======================================
+ Hits         2731     2743   +12     
  Misses         30       30           
Impacted Files Coverage Δ
src/checks/quote_character.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Ensure that values containing would-be comments are not altered by
stripping quotes.

Refs: #559
@DDtKey DDtKey requested a review from a team October 13, 2022 12:51
@mgrachev mgrachev linked an issue Oct 17, 2022 that may be closed by this pull request
@mgrachev mgrachev merged commit d9876ed into dotenv-linter:master Oct 17, 2022
@mgrachev
Copy link
Member

@95jonpet 👋 Thank you for your contribution 🚀

@95jonpet 95jonpet deleted the issue-559 branch October 23, 2022 17:27
zd4y added a commit to zd4y/dotenv-linter that referenced this pull request Nov 1, 2022
fix: check that tag is valid semver

fix: make sure tag starts with v and update error message

fix: move tag validation to function

fix: replace bash extensions with normal sh

doc: add commit standard for the CONTRIBUTION file (dotenv-linter#561)

chore: bump boa-dev/criterion-compare-action from 3.2.2 to 3.2.3 (dotenv-linter#570)

Bumps [boa-dev/criterion-compare-action](https://github.com/boa-dev/criterion-compare-action) from 3.2.2 to 3.2.3.
- [Release notes](https://github.com/boa-dev/criterion-compare-action/releases)
- [Commits](boa-dev/criterion-compare-action@v3.2.2...v3.2.3)

---
updated-dependencies:
- dependency-name: boa-dev/criterion-compare-action
  dependency-type: direct:production
  update-type: version-update:semver-patch

chore: bump wagoid/commitlint-github-action from 5.0.2 to 5.2.0 (dotenv-linter#565)

Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 5.0.2 to 5.2.0.
- [Release notes](https://github.com/wagoid/commitlint-github-action/releases)
- [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md)
- [Commits](wagoid/commitlint-github-action@v5.0.2...v5.2.0)

---
updated-dependencies:
- dependency-name: wagoid/commitlint-github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor

chore: bump dunce from 1.0.2 to 1.0.3 (dotenv-linter#564)

Bumps [dunce](https://gitlab.com/kornelski/dunce) from 1.0.2 to 1.0.3.
- [Release notes](https://gitlab.com/kornelski/dunce/tags)
- [Commits](https://gitlab.com/kornelski/dunce/commits/v1.0.3)

---
updated-dependencies:
- dependency-name: dunce
  dependency-type: direct:production
  update-type: version-update:semver-patch

chore: bump Swatinem/rust-cache from 2.0.0 to 2.0.1 (dotenv-linter#571)

Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/Swatinem/rust-cache/releases)
- [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md)
- [Commits](Swatinem/rust-cache@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: Swatinem/rust-cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: don't remove quotes for values containing hash-sign (dotenv-linter#560)

Ensure that values containing would-be comments are not altered by
stripping quotes.

Refs: dotenv-linter#559

chore: bump criterion from 0.3.6 to 0.4.0 (dotenv-linter#575)

ci: temporarily disable docker arm64 build (dotenv-linter#577)

ci: replace `actions-rs/toolchain` with `dtolnay/rust-toolchain` (dotenv-linter#573)

Because `actions-rs` [is unmaintained](actions-rs/toolchain#216).

chore: bump assert_cmd from 2.0.4 to 2.0.5 (dotenv-linter#578)

Bumps [assert_cmd](https://github.com/assert-rs/assert_cmd) from 2.0.4 to 2.0.5.
- [Release notes](https://github.com/assert-rs/assert_cmd/releases)
- [Changelog](https://github.com/assert-rs/assert_cmd/blob/master/CHANGELOG.md)
- [Commits](assert-rs/assert_cmd@v2.0.4...v2.0.5)

ci: add checks for install with tag

ci: remove tag 'not a tag' from job

ci: replace == with = in test

chore: bump boa-dev/criterion-compare-action from 3.2.3 to 3.2.4 (dotenv-linter#580)

Bumps [boa-dev/criterion-compare-action](https://github.com/boa-dev/criterion-compare-action) from 3.2.3 to 3.2.4.
- [Release notes](https://github.com/boa-dev/criterion-compare-action/releases)
- [Commits](boa-dev/criterion-compare-action@v3.2.3...v3.2.4)

---
updated-dependencies:
- dependency-name: boa-dev/criterion-compare-action
  dependency-type: direct:production
  update-type: version-update:semver-patch

ci: fix matrix.shell

ci: remove matrix.shell and os:windows-latest

ci: fix install_specific_versions_wrong_input job and add windows jobs

fix: use `grep -E` instead of `grep -P`

ci: fix wrong input jobs

ci: remove non-existent windows releases and redirect install.sh stderr to stdout in wrong input jobs

ci: fix error message test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remove quote on string containing "#"

4 participants