[release/9.0.1xx] fix Microsoft.NET.Sdk.Android.Manifest-9.0.100 version band
#10112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion band In fc72bb4, we migrated to a 9.0.300 .NET SDK, which unfortunately resulted in an Android workload manifest with a 9.0.300 version band: Microsoft.NET.Sdk.Android.Manifest-9.0.300.35.0.73.nupkg To stay on 9.0.100, we need to also set `$(DotNetSdkManifestsFolder)` in `eng/Versions.props` in addition to the other properties we set in fc72bb4.
|
Package name looks correct now:
|
pjcollins
approved these changes
May 6, 2025
|
I think something is breaking on the Windows lane: I'm going to try a different property. |
jonathanpeppers
added a commit
that referenced
this pull request
May 7, 2025
Backport of: #10112 In fc72bb4, we migrated to a 9.0.300 .NET SDK, which unfortunately resulted in an Android workload manifest with a 9.0.300 version band: Microsoft.NET.Sdk.Android.Manifest-9.0.300.35.0.73.nupkg To stay on 9.0.100, we need should use `$(DotNetAndroidManifestVersionBand)` for the manifest version band instead of `$(DotNetSdkManifestsFolder)`. I also had to make a similar change in `DotNet.targets`.
jonathanpeppers
added a commit
that referenced
this pull request
May 7, 2025
Backport of: #10112 In fc72bb4, we migrated to a 9.0.300 .NET SDK, which unfortunately resulted in an Android workload manifest with a 9.0.300 version band: Microsoft.NET.Sdk.Android.Manifest-9.0.300.35.0.73.nupkg To stay on 9.0.100, we need should use `$(DotNetAndroidManifestVersionBand)` for the manifest version band instead of `$(DotNetSdkManifestsFolder)`. I also had to make a similar change in `DotNet.targets`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fc72bb4, we migrated to a 9.0.300 .NET SDK, which unfortunately resulted in an Android workload manifest with a 9.0.300 version band:
To stay on 9.0.100, we need to also set
$(DotNetSdkManifestsFolder)ineng/Versions.propsin addition to the other properties we set in fc72bb4.