KEMBAR78
[tests] fix `GetString_Many()` test by jonathanpeppers · Pull Request #10317 · dotnet/android · GitHub
Skip to content

Conversation

@jonathanpeppers
Copy link
Member

The test is currently failing with:

Expected: True
But was:  False
Stack trace
   at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.GetString_Many()
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )

If I navigate to http://example.org in a browser, I just get a DNS error.

There are other tests in here that use https://google.com instead, so I switched to use it.

I also removed the MobileNotWorking category, which doesn't appear to be actually ignored because the test is running?

The test is currently failing with:

    Expected: True
    But was:  False
    Stack trace
       at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.GetString_Many()
       at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
       at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )

If I navigate to http://example.org in a browser, I just get a DNS error.

There are other tests in here that use https://google.com instead, so
I switched to use it.

I also removed the `MobileNotWorking` category, which doesn't appear
to be actually ignored because the test is running?
@jonathanpeppers
Copy link
Member Author

This is passing now on all configurations:

image

@jonathanpeppers jonathanpeppers merged commit 0282d75 into main Jul 22, 2025
56 of 59 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/GetString_Many branch July 22, 2025 16:51
jonathanpeppers added a commit that referenced this pull request Jul 22, 2025
The test is currently failing with:

    Expected: True
    But was:  False
    Stack trace
       at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.GetString_Many()
       at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
       at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )

If I navigate to http://example.org in a browser, I just get a DNS error.

There are other tests in here that use https://google.com instead, so
I switched to use it.

I also removed the `MobileNotWorking` category, which doesn't appear
to be actually ignored because the test is running?
jonathanpeppers added a commit that referenced this pull request Jul 23, 2025
The test is currently failing with:

    Expected: True
    But was:  False
    Stack trace
       at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.GetString_Many()
       at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
       at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )

If I navigate to http://example.org in a browser, I just get a DNS error.

There are other tests in here that use https://google.com instead, so
I switched to use it.

I also removed the `MobileNotWorking` category, which doesn't appear
to be actually ignored because the test is running?
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant