KEMBAR78
[Arm64] Base HW Intrinsics by sdmaclea · Pull Request #16822 · dotnet/coreclr · GitHub
Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@sdmaclea
Copy link

@sdmaclea sdmaclea commented Mar 8, 2018

@dotnet/arm64-contrib @CarolEidt @RussKeldorph @eerhardt @tannergooding PTAL


// Reflection call
var issupported = "get_IsSupported";
bool reflectedIsSupported = Convert.ToBoolean(typeof(Simd).GetMethod(issupported).Invoke(null, null));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simd should be Base

@sdmaclea sdmaclea force-pushed the PR-ARM64-BASE-INTRINSICS branch from 1c6f74f to d8ac38e Compare March 8, 2018 17:05
Copy link

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I would like to see us improve the tests to get broader coverage, but I'm OK with leaving that for future.

@sdmaclea sdmaclea force-pushed the PR-ARM64-BASE-INTRINSICS branch from d8ac38e to 40f7302 Compare March 10, 2018 21:39
@sdmaclea
Copy link
Author

Disabled the test until API is added in corefx

@sdmaclea
Copy link
Author

timeout cloning repo...
test Windows_NT arm64 Cross Checked Innerloop Build and Test

@sdmaclea
Copy link
Author

Can this be merged?

@CarolEidt CarolEidt merged commit 23b4f68 into dotnet:master Mar 13, 2018
@sdmaclea sdmaclea deleted the PR-ARM64-BASE-INTRINSICS branch May 24, 2018 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants