Update SqlServerStrings.Designer.cs #24020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the class which contains the SavepointsDisabledBecauseOfMARS is SqlServerEventId, not RelationalEventId.
|
Thanks @vincent1405 - but note the Designer file is auto-generated. Can you please update the resx as well? |
|
|
|
@vincent1405 I've added a commit to fix the resx as well, so this is ready for merging. However, you'll need to sign the SLA (link above) before we can merge this PR. |
|
@roji Thank you, sorry, I had no time to update the resx. |
roji
approved these changes
Feb 4, 2021
|
Thanks @vincent1405, merged. |
|
Thanks @roji ! |
Ali-YousefiTelori
pushed a commit
to Ali-YousefiTelori/EntityFrameworkCore
that referenced
this pull request
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
.ConfigureWarnings(w => w.Throw(RelationalEventId.SavepointsDisabledBecauseOfMARS));to our optionsBuilder in the DbContext.
The SavepointsDisabledBecauseOfMARS is not a member of RelationalEventId but is a member of SqlServerEventId.
Fixes #24019