KEMBAR78
Added DbUpdateException constructors that accept list of EntityEntry for Entries property by Giorgi · Pull Request #24147 · dotnet/efcore · GitHub
Skip to content

Conversation

@Giorgi
Copy link
Contributor

@Giorgi Giorgi commented Feb 13, 2021

Implements #24146

@dnfadmin
Copy link

dnfadmin commented Feb 13, 2021

CLA assistant check
All CLA requirements met.

@Giorgi Giorgi closed this Feb 13, 2021
@Giorgi Giorgi reopened this Feb 13, 2021
@Giorgi
Copy link
Contributor Author

Giorgi commented Feb 13, 2021

The new constructor should filter entities by state too but I'll wait for the review before making that change.

@ajcvickers ajcvickers self-assigned this Feb 16, 2021
@ajcvickers
Copy link
Contributor

@Giorgi This looks good to me. I don't think the constructor should do any filtering; I think the caller should filter before calling the constructor.

Can you add some simple unit tests in ExceptionTest.cs? Just test that calling the constructor results in the Entries property returning the passed in entries.

@Giorgi
Copy link
Contributor Author

Giorgi commented Feb 17, 2021

@ajcvickers Done

@ajcvickers
Copy link
Contributor

@Giorgi Thanks!

@Giorgi
Copy link
Contributor Author

Giorgi commented Feb 19, 2021

@ajcvickers Any chance to see this change in the 5.X version? Just saw that the issue has 6.0 milestone applied to it.

@roji
Copy link
Member

roji commented Feb 19, 2021

@Giorgi yeah, once a version has been released (5.0), we only patch for bugs, and not new features or APIs (and even for bugs, they need to be low-risk and relatively severe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants