KEMBAR78
Translate DateTimeOffset.ToUnixTime[Seconds|Milliseconds] by Marusyk · Pull Request #28978 · dotnet/efcore · GitHub
Skip to content

Translate DateTimeOffset.ToUnixTime[Seconds|Milliseconds] #28978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

Translate DateTimeOffset.ToUnixTime[Seconds|Milliseconds] #28978

merged 2 commits into from
Mar 30, 2023

Conversation

@Marusyk
Copy link
Member

@Marusyk Marusyk commented Sep 4, 2022 •
edited
Loading

Added translation for DateTimeOffset.ToUnixTime[Seconds|Milliseconds]

Fixes #28925

Could anyone help me improve the tests?
Thank you in advance

@Marusyk Marusyk requested a review from dougbu as a code owner September 4, 2022 01:32
@Marusyk Marusyk changed the base branch from release/7.0 to main September 4, 2022 01:34
roji
roji previously requested changes Sep 4, 2022
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also SQLite test failures, you probably need to implement those tests and assert on them failing (unless there's a translation on SQLite as well).

@ajcvickers
Copy link
Contributor

Marked as blocked since we shouldn't merge until we are actively working in main again.

@smitpatel
Copy link
Contributor

Cosmos has DateTimeToTicks which returns ticks since unix epoch though not sure if Cosmos can handle DateTimeOffset as a type. Add translation if it is supported.

@roji
Copy link
Member

roji commented Sep 7, 2022

Converting to draft for now as we're not merging this for 7.0.

@roji roji marked this pull request as draft September 7, 2022 06:43
bricelam
bricelam reviewed Sep 7, 2022
View reviewed changes
Marusyk
Marusyk commented Sep 11, 2022
View reviewed changes
@Marusyk
Copy link
Member Author

Marusyk commented Nov 11, 2022

Can I mark it "ready for review"?

@bricelam bricelam marked this pull request as ready for review December 9, 2022 21:27
@bricelam bricelam removed the blocked label Dec 9, 2022
bricelam added a commit to Marusyk/efcore that referenced this pull request Mar 20, 2023
@bricelam
Clean up PR dotnet#28978
e1b3468
@bricelam
Copy link
Contributor

bricelam commented Mar 20, 2023 •
edited
Loading

Rebased, removed SQLite translations, and propagated the type mapping from instance to UnixEpoch.

bricelam added a commit to Marusyk/efcore that referenced this pull request Mar 21, 2023
@bricelam
Clean up PR dotnet#28978
22d4490
@bricelam bricelam merged commit 72ab932 into dotnet:main Mar 30, 2023
@ajcvickers ajcvickers mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji left review comments

@dougbu dougbu Awaiting requested review from dougbu

+2 more reviewers

@smitpatel smitpatel smitpatel left review comments

@bricelam bricelam bricelam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bricelam bricelam

Labels

community-contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Translate DateTimeOffset.ToUnixTime[Seconds|Milliseconds]

5 participants

@Marusyk @ajcvickers @smitpatel @roji @bricelam