Use feature flags for CFNetworkHandler and NSUrlSessionHandler #22703

mcumming · 2025-04-30T16:02:58Z

Continuation of #19003

This means the linker will remove either CFNetworkHandler or NSUrlSessionHandler depending on which is chosen at build time (or both, if neither is chosen).

This will shrink app size a little bit, here are the types and members that are no longer included when using NSUrlSessionHandler: https://gist.github.com/rolfbjarne/102d77d5f105a7c98ac6be19de725dd5

A very basic app is ~55kb / 0.2% smaller: https://gist.github.com/rolfbjarne/a1cb6898aa560f0a891286be20b9bc3e

Fixes #14298.

github-actions · 2025-04-30T16:07:07Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2025-04-30T16:28:42Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2025-05-01T03:12:28Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/ObjCRuntime/RuntimeOptions.cs

…ol properties

…ionHandler

…dler

rolfbjarne · 2025-05-19T06:42:53Z

I'll take over this.

…switch-cfnetworkhandler

vs-mobiletools-engineering-service2 · 2025-05-19T17:53:32Z

✅ [PR Build #909d1ed] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-19T18:05:31Z

✅ [CI Build #909d1ed] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-19T18:19:44Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-19T19:12:07Z

✅ [CI Build #909d1ed] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-19T19:25:15Z

💻 [CI Build #909d1ed] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-19T19:28:00Z

💻 [CI Build #909d1ed] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-20T06:42:18Z

💻 [CI Build #909d1ed] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-20T06:42:41Z

💻 [CI Build #909d1ed] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-20T06:46:18Z

🚀 [CI Build #909d1ed] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 118 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 909d1ed220dc85aec278274fbdfe21a344abfe14 [PR build]

…eHttpHandler='false'. This makes this code in project files work (which it used to, until #22703, because our submission tests do this): ```xml <MtouchHttpClientHandler>HttpClientHandler</MtouchHttpClientHandler> ```

…eHttpHandler='false'. (#23261) This makes this code in project files work (which it used to, until #22703, because our submission tests do this): ```xml <MtouchHttpClientHandler>HttpClientHandler</MtouchHttpClientHandler> ```

mcumming changed the title ~~USe feature flags for CFNetworkHandler and NSUrlSessionHandler~~ Use feature flags for CFNetworkHandler and NSUrlSessionHandler Apr 30, 2025

mcumming requested a review from rolfbjarne April 30, 2025 16:05

This comment has been minimized.

Sign in to view

rolfbjarne requested changes May 1, 2025

View reviewed changes

src/ObjCRuntime/RuntimeOptions.cs Show resolved Hide resolved

src/ObjCRuntime/RuntimeOptions.cs Outdated Show resolved Hide resolved

rolfbjarne approved these changes May 1, 2025

View reviewed changes

src/ObjCRuntime/RuntimeOptions.cs Outdated Show resolved Hide resolved

src/ObjCRuntime/RuntimeOptions.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes May 1, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Agnik7 and others added 7 commits May 1, 2025 10:26

Add UseCFNetworkHandler and UseNSUrlSessionHandler internal static bo…

728fc35

…ol properties

Compute the value for properties UseCFNetworkHandler and UseNSUrlSess…

b8ec6b7

…ionHandler

Reworked code to use 2 new Runtime properties

9c46eba

Fixed compilation errors, moved logic to Read() method.

51e8d6b

Fixed formatting

8d1262b

Auto-format source code

4cf9612

Created backing fields for UseCFNetworkHandler and UseNSURLSessionHan…

1614113

…dler

This comment has been minimized.

Sign in to view

rolfbjarne self-assigned this May 19, 2025

rolfbjarne added 4 commits May 19, 2025 09:14

Merge remote-tracking branch 'origin/main' into dev/mcumming/feature-…

614ed2a

…switch-cfnetworkhandler

Update feature name.

4977565

Add unit test.

b067576

Merge remote-tracking branch 'origin/main' into dev/mcumming/feature-…

909d1ed

…switch-cfnetworkhandler

This comment has been minimized.

Sign in to view

rolfbjarne added the app-size label May 20, 2025

dalexsoto approved these changes May 20, 2025

View reviewed changes

rolfbjarne merged commit 30ebb25 into main May 20, 2025
44 checks passed

rolfbjarne deleted the dev/mcumming/feature-switch-cfnetworkhandler branch May 20, 2025 17:27

rolfbjarne mentioned this pull request Jul 4, 2025

[dotnet] Treat MtouchHttpClientClient='HttpClientHandler' as UseNativeHttpHandler='false'. #23261

Merged

Use feature flags for CFNetworkHandler and NSUrlSessionHandler #22703

Use feature flags for CFNetworkHandler and NSUrlSessionHandler #22703

Uh oh!

Conversation

mcumming commented Apr 30, 2025 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 30, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 30, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented May 1, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented May 19, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented May 19, 2025

✅ [PR Build #909d1ed] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 19, 2025

✅ [CI Build #909d1ed] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 19, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 19, 2025

✅ [CI Build #909d1ed] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 19, 2025

💻 [CI Build #909d1ed] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 19, 2025

💻 [CI Build #909d1ed] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 20, 2025

💻 [CI Build #909d1ed] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 20, 2025

💻 [CI Build #909d1ed] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 20, 2025

🚀 [CI Build #909d1ed] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

mcumming commented Apr 30, 2025 •

edited by rolfbjarne

Loading