[msbuild] Enable nullability in most files and fix any issues. #22857

rolfbjarne · 2025-05-20T18:46:48Z

This also required bumping Xamarin.MacDev.

New commits in xamarin/Xamarin.MacDev:

dotnet/macios-devtools@b75e982 [Xamarin.MacDev] A few nullability improvements.
dotnet/macios-devtools@8c44b7f Renamed paths to remove "Xamarin" and start using "maui"
dotnet/macios-devtools@fd6a292 Add a Code of Conduct.
dotnet/macios-devtools@d6a4853 Create dependabot.yml to update GitHub actions automatically

Diff: https://github.com/xamarin/Xamarin.MacDev/compare/5b7cf7c1a99fd3b12c7235d2778990023e84eb9c..b75e9820ed2da79942fd5bec1000acb2063229dc

This also required bumping Xamarin.MacDev. New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@b75e982 [Xamarin.MacDev] A few nullability improvements. * dotnet/macios-devtools@8c44b7f Renamed paths to remove "Xamarin" and start using "maui" * dotnet/macios-devtools@fd6a292 Add a Code of Conduct. * dotnet/macios-devtools@d6a4853 Create dependabot.yml to update GitHub actions automatically Diff: https://github.com/xamarin/Xamarin.MacDev/compare/5b7cf7c1a99fd3b12c7235d2778990023e84eb9c..b75e9820ed2da79942fd5bec1000acb2063229dc

…ability

vs-mobiletools-engineering-service2 · 2025-05-22T09:18:37Z

✅ [CI Build #ac2cce6] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T09:42:27Z

✅ [PR Build #ac2cce6] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T09:50:10Z

✅ [CI Build #ac2cce6] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T10:01:54Z

💻 [CI Build #ac2cce6] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T10:03:17Z

💻 [CI Build #ac2cce6] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T10:05:08Z

💻 [CI Build #ac2cce6] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T10:05:47Z

💻 [CI Build #ac2cce6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T10:31:51Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

vs-mobiletools-engineering-service2 · 2025-05-22T12:00:26Z

🚀 [CI Build #ac2cce6] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ac2cce62efa584b0d9b2bb952904630f843960aa [PR build]

rolfbjarne requested review from emaf and mauroa as code owners May 20, 2025 18:46

Auto-format source code

3b00dfa

This comment has been minimized.

Sign in to view

dalexsoto approved these changes May 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mauroa approved these changes May 21, 2025

View reviewed changes

emaf approved these changes May 21, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/msbuild-null…

0e6cde2

…ability

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits May 22, 2025 09:51

Fix nullable output.

84b8add

Merge remote-tracking branch 'origin/main' into dev/rolf/msbuild-null…

ac2cce6

…ability

rolfbjarne merged commit 0a62c2b into main May 22, 2025
44 checks passed

rolfbjarne deleted the dev/rolf/msbuild-nullability branch May 22, 2025 14:47

[msbuild] Enable nullability in most files and fix any issues. #22857

[msbuild] Enable nullability in most files and fix any issues. #22857

Uh oh!

Conversation

rolfbjarne commented May 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 22, 2025

✅ [CI Build #ac2cce6] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

✅ [PR Build #ac2cce6] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

✅ [CI Build #ac2cce6] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

💻 [CI Build #ac2cce6] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

💻 [CI Build #ac2cce6] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

💻 [CI Build #ac2cce6] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

💻 [CI Build #ac2cce6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 22, 2025

🚀 [CI Build #ac2cce6] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants