[android] improve layout performance of Label #14980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #12130
Context: https://github.com/angelru/CvSlowJittering
Context: https://github.com/jonathanpeppers/lols
Testing a customer sample and my LOLs per second sample, I could see a lot of time (5.1%) spent in
PrepareForTextViewArrange():Most of the time is spent just calling
View.Contextto be able to do:In eea91d3, I added an overload for
ToPixels()that allows you to get the same value with anAndroid.Views.View-- avoiding the need to callView.Context.So we can instead do:
After these changes, it seems to be ~2.7% better:
The
View.Contextcall is now completely gone.It appears to show a good result in the LOLs/second sample as well: