KEMBAR78
[iOS] Span's TapGestureRecognizer not working if text is truncated - UITest by kubaflo · Pull Request #22213 · dotnet/maui · GitHub
Skip to content

[iOS] Span's TapGestureRecognizer not working if text is truncated - UITest #22213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[iOS] Span's TapGestureRecognizer not working if text is truncated - UITest #22213

merged 1 commit into from
Aug 15, 2025

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented May 5, 2024

Issues Fixed

Windows is not working either, but I have no machine to work on it
Fixes #21837

Before After
Screen.Recording.2024-05-05.at.20.33.23.mov
Screen.Recording.2024-05-05.at.20.31.50.mov

@kubaflo kubaflo requested a review from a team as a code owner May 5, 2024 22:48
@kubaflo kubaflo requested review from PureWeen and mattleibow May 5, 2024 22:48
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 5, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz reviewed May 7, 2024
View reviewed changes
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz requested changes May 14, 2024
View reviewed changes
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@artemvalieiev artemvalieiev mentioned this pull request May 17, 2024
Merged
jsuarezruiz
jsuarezruiz previously approved these changes Jun 10, 2024
View reviewed changes
tj-devel709
tj-devel709 requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in the right direction and definitely when there is truncation, this is not working correctly because it is looking for the rect around the last character but that character is not rendered and get an empty rect.

The issue I see with using the finalSize.Bottom is when we have a frame that is longer than the span we'd like, there is extra space being added to the 'hitbox' area of the span that we do not want.

Screen.Recording.2024-07-11.at.5.08.17.PM.mov 
<Label AutomationId="label7" HorizontalOptions="Start" MaxLines="5" BackgroundColor="LightGoldenrodYellow" WidthRequest="200" HeightRequest="400">
            <Label.FormattedText>
                <FormattedString>
                    <Span Text="Only our MaxLines differ. Otherwise we're the same. Please tap us!">
                        <Span.GestureRecognizers>
                            <TapGestureRecognizer Command="{Binding TapCommand}" />
                        </Span.GestureRecognizers>
                    </Span>
                </FormattedString>
            </Label.FormattedText>
        </Label>

This is a great idea though and maybe it can be tweaked to find a good middle ground

@tj-devel709
Copy link
Member

Perhaps something like a check if the endRect is the empty rect and the startRect is not the empty rect, then maybe that is enough to assume there is truncation going on and we can use the finalSize?

@kubaflo
Copy link
Contributor Author

kubaflo commented Mar 16, 2025

Hi @tj-devel709 I've rebased and the issue seems to be fixed. So maybe just merge the UI test I've added and close this bug?

@kubaflo kubaflo changed the title [iOS] Span's TapGestureRecognizer not working if text is truncated [iOS] Span's TapGestureRecognizer not working if text is truncated - uiTest Mar 16, 2025
@kubaflo kubaflo changed the title [iOS] Span's TapGestureRecognizer not working if text is truncated - uiTest [iOS] Span's TapGestureRecognizer not working if text is truncated - UITest Mar 16, 2025
@kubaflo kubaflo self-assigned this Mar 16, 2025
@mattleibow
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/current August 15, 2025 23:23
@PureWeen PureWeen merged commit 567aa26 into dotnet:inflight/current Aug 15, 2025
76 of 78 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
@kubaflo @PureWeen
Issue #21837 - UITest (#22213)
0fb06e7
github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
@kubaflo @PureWeen
Issue #21837 - UITest (#22213)
620896e
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
@kubaflo @PureWeen
Issue #21837 - UITest (#22213)
30af3d5
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tj-devel709 tj-devel709 tj-devel709 requested changes

@mattleibow mattleibow mattleibow approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@kubaflo kubaflo

Labels

area-gestures Gesture types community ✨ Community Contribution platform/ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Span's TapGestureRecognizer not working if text is truncated

5 participants

@kubaflo @jsuarezruiz @tj-devel709 @mattleibow @PureWeen