Changing shape background color with dataTrigger #25544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/windows
platform/android
area-drawing
|
/azp run |
jsuarezruiz
requested changes
Oct 28, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jsuarezruiz added snapshots :) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Foda
previously approved these changes
Nov 14, 2024
jsuarezruiz
previously approved these changes
Nov 15, 2024
PureWeen
requested changes
Nov 23, 2024
| handler.ToPlatform().UpdateBackground(shapeView); | ||
| } | ||
|
|
||
| if (shapeView.Background is not null || shapeView.Fill is not null) |
There was a problem hiding this comment.
Can we move this whole method into the shared file?
It seems like this method is identical between all three platforms
mattleibow
approved these changes
Jun 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
* Changing shape background color with dataTrigger * Refactor
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
* Changing shape background color with dataTrigger * Refactor
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
* Changing shape background color with dataTrigger * Refactor
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
* Changing shape background color with dataTrigger * Refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #25385
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-10-27.at.13.27.43.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-10-27.at.13.24.29.mp4