KEMBAR78
[Android] Toolbar overflow menu icon color by kubaflo · Pull Request #25627 · dotnet/maui · GitHub
Skip to content

[Android] Toolbar overflow menu icon color #25627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[Android] Toolbar overflow menu icon color #25627

merged 1 commit into from
Aug 11, 2025

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Oct 31, 2024 •
edited by jfversluis
Loading

Description of Change

The icon color was respected when setting this value directly for the content page NavigationPage.IconColor="Red", but if it was not set there then it has not been picked from its parent navigation page

Issues Fixed

Fixes #23563
Fixes #29184

Before After

@kubaflo kubaflo requested a review from a team as a code owner October 31, 2024 12:11
@dotnet-policy-service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 31, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Oct 31, 2024
@jsuarezruiz jsuarezruiz self-requested a review November 4, 2024 07:54
@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

rmarinho commented Nov 28, 2024 •
edited by jfversluis
Loading

/rebase

@kubaflo kubaflo force-pushed the fix-23563 branch 2 times, most recently from 83d3afa to 5754cc2 Compare March 18, 2025 14:57
@kubaflo kubaflo self-assigned this Mar 18, 2025
@jsuarezruiz jsuarezruiz mentioned this pull request Apr 25, 2025
Closed
@jsuarezruiz
Copy link
Contributor

This PR should also fix #29184

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis
Copy link
Member

/rebase

@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 10:32
Copilot
Copilot AI reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jfversluis
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis changed the base branch from main to inflight/current August 11, 2025 13:15
@jfversluis jfversluis merged commit 4349655 into dotnet:inflight/current Aug 11, 2025
github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
@kubaflo @PureWeen
[Android] Toolbar overflow menu icon color (#25627)
15b62c1
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
@kubaflo @PureWeen
[Android] Toolbar overflow menu icon color (#25627)
026eb57
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
@kubaflo @PureWeen
[Android] Toolbar overflow menu icon color (#25627)
636b6f9
github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
@kubaflo @PureWeen
[Android] Toolbar overflow menu icon color (#25627)
1081266
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
@kubaflo @PureWeen
[Android] Toolbar overflow menu icon color (#25627)
4e565b9
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

@jfversluis jfversluis jfversluis approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@kubaflo kubaflo

Labels

area-controls-toolbar ToolBar area-navigation NavigationPage community ✨ Community Contribution platform/android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the more menu button on MAUI ContentPage.ToolbarItems Unable to set toolbar overflow menu color if not using shell.

4 participants

@kubaflo @jsuarezruiz @rmarinho @jfversluis