KEMBAR78
[iOS] Thumb image improvements by kubaflo · Pull Request #27516 · dotnet/maui · GitHub
Skip to content

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 1, 2025

Issues Fixed

Fixes #27515
Fixes #27475

Before After
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-02-01.at.11.04.22.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-02-01.at.11.03.01.mp4

@kubaflo kubaflo requested a review from a team as a code owner February 1, 2025 15:15
@dotnet-policy-service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

App.WaitForElement("ChangeThumbImageButton");
App.Click("ChangeThumbImageButton");
App.Click("ChangeThumbColorButton");
VerifyScreenshot();
Copy link
Contributor

@jsuarezruiz jsuarezruiz Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots already available in the latest build:
image

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 3, 2025

@jsuarezruiz done

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

@kubaflo kubaflo self-assigned this May 10, 2025
@kubaflo kubaflo force-pushed the thumb-image-fixes branch from 2fde415 to cf49c49 Compare May 10, 2025 21:42
@jfversluis
Copy link
Member

/rebase

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 15:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jfversluis jfversluis changed the base branch from main to inflight/current August 12, 2025 15:21
@jfversluis jfversluis merged commit ae25749 into dotnet:inflight/current Aug 12, 2025
1 check passed
@jfversluis jfversluis added this to the .NET 9 SR11 milestone Aug 12, 2025
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
* [iOS] Thumb image improvements

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
* [iOS] Thumb image improvements

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
* [iOS] Thumb image improvements

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
* [iOS] Thumb image improvements

* Added snapshots
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Slider's thumb image doesn't respect color Thumb Image Disappears in Slider Control When Changing Thumb Color on iOS and Catalyst

3 participants