-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] CV1 & CV2 - Support for RTL #27653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] CV1 & CV2 - Support for RTL #27653
Conversation
@kubaflo Are the videos in #27653 (comment) switched possibly? Looks like "Before" behaves better than "After". :) |
@MartyIX yeah, thanks for letting me know:) |
9f02b26
to
45b33af
Compare
Hi! @rmarinho what do you think? |
507164d
to
2b81de6
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
2b81de6
to
1fa53e0
Compare
@kubaflo, This fix resolves the issue for CollectionView when using a DataTemplate. However, when using a static string as the ItemsSource, the flow direction is still not respected (see issue #29799 for reference). Also, could you update the template 'Fixes' section so that it links to the actual issue(#27711) instead of this pull request |
@HarishwaranVijayakumar I've added a commit that fixes it |
Added a UITest Fix for default cells
Description
This PR hopefully fixes a bunch of legacy Xamarin bugs related to RTL in the Collection View
Issues Fixed
Fixes #29799
Fixes #27711
xamarin/Xamarin.Forms#12633
xamarin/Xamarin.Forms#14149
xamarin/Xamarin.Forms#13165
xamarin/Xamarin.Forms#8759
xamarin/Xamarin.Forms#8260
cv2-before.mp4
cv2-after.mp4
cv1-before.mp4
cv1-after.mp4