KEMBAR78
[iOS] CV1 & CV2 - Support for RTL by kubaflo · Pull Request #27653 · dotnet/maui · GitHub
Skip to content

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 9, 2025

Description

This PR hopefully fixes a bunch of legacy Xamarin bugs related to RTL in the Collection View

Issues Fixed

Fixes #29799
Fixes #27711
xamarin/Xamarin.Forms#12633
xamarin/Xamarin.Forms#14149
xamarin/Xamarin.Forms#13165
xamarin/Xamarin.Forms#8759
xamarin/Xamarin.Forms#8260

Before - CV 2 After - CV 2
cv2-before.mp4
cv2-after.mp4
Before - CV 1 After - CV 1
cv1-before.mp4
cv1-after.mp4

@MartyIX
Copy link
Contributor

MartyIX commented Feb 10, 2025

@kubaflo Are the videos in #27653 (comment) switched possibly? Looks like "Before" behaves better than "After". :)

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 10, 2025

@MartyIX yeah, thanks for letting me know:)

@kubaflo kubaflo force-pushed the support-for-rtl-cv1 branch from 9f02b26 to 45b33af Compare February 10, 2025 18:50
@kubaflo kubaflo changed the title [iOS] CV1 - Support for RTL [iOS] CV1 & CV2 - Support for RTL Feb 10, 2025
@kubaflo kubaflo requested a review from rmarinho February 10, 2025 18:56
@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 10, 2025

Hi! @rmarinho what do you think?

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho added this to the .NET 9 SR5 milestone Feb 12, 2025
@rmarinho rmarinho self-assigned this Feb 12, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR5, .NET 9 SR6 Mar 7, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR6, .NET 9 SR7 Mar 24, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR7, .NET 9 SR8 May 8, 2025
@kubaflo kubaflo self-assigned this May 10, 2025
@kubaflo kubaflo force-pushed the support-for-rtl-cv1 branch from 2b81de6 to 1fa53e0 Compare May 10, 2025 22:07
@HarishwaranVijayakumar
Copy link
Contributor

@kubaflo, This fix resolves the issue for CollectionView when using a DataTemplate. However, when using a static string as the ItemsSource, the flow direction is still not respected (see issue #29799 for reference). Also, could you update the template 'Fixes' section so that it links to the actual issue(#27711) instead of this pull request

@kubaflo
Copy link
Contributor Author

kubaflo commented Jun 3, 2025

@HarishwaranVijayakumar I've added a commit that fixes it

@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Sep 2, 2025
@jfversluis jfversluis changed the base branch from main to inflight/current September 2, 2025 12:03
@jfversluis jfversluis merged commit 896b863 into dotnet:inflight/current Sep 2, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Sep 2, 2025
PureWeen pushed a commit that referenced this pull request Sep 8, 2025
Added a UITest

Fix for default cells
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/ios

Projects

Status: Done

7 participants