[Proposal] Removed the default span styling from the template #28818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/Controls/samples/Controls.Sample.Embedding/Resources/Styles/Styles.xaml: Language not supported
- src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml: Language not supported
- src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml: Language not supported
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/Controls/samples/Controls.Sample.Embedding/Resources/Styles/Styles.xaml: Language not supported
- src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml: Language not supported
- src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml: Language not supported
kubaflo
changed the title
|
AFAIK the Label style doesn't go down to Spans, is that different for TextColor? |
|
They used not to but currently they do. And, I think that it has been put in the template because it didn't work in the past <ContentPage.Resources>
<Style TargetType="Label">
<Setter Property="TextColor"
Value="Green"/>
<Setter Property="FontSize"
Value="35"/>
</Style>
</ContentPage.Resources>
<Label>
<Label.FormattedText>
<FormattedString>
<Span>Hello</Span>
<Span Text=" World"/>
</FormattedString>
</Label.FormattedText>
</Label>
|
kubaflo
added
proposal/open
area-templates
|
/rebase |
github-actions
bot
force-pushed
the
maui-span-template
branch
from
d399ad6 to
cf98695
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 6, 2025
PureWeen
pushed a commit
that referenced
this pull request
Aug 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Some developers prefer to use global styles for their Label controls and expect that properties like
TextColorwill cascade to Span. However, the defaultStyles.xamlfile in the MAUI template includes an explicit style targeting Span, which overrides inherited properties—specificallyTextColor.This default Span style unnecessarily duplicates the
TextColorof Label, causing confusion when global styles don't behave as expected. Removing the Span style resolves the issue by allowing properties such as TextColor to be inherited from the parent Label, as intended.This change simplifies styling and ensures a more consistent and predictable behavior for developers customizing label appearance via global styles.