Fix Crash when ItemsSource is set to null in the SelectionChanged handler #29887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
reviewed
Jun 9, 2025
src/Controls/src/Core/Handlers/Items/iOS/SelectableItemsViewController.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Jun 10, 2025
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
sheiksyedm
reviewed
Jun 10, 2025
src/Controls/src/Core/Handlers/Items/iOS/SelectableItemsViewController.cs
Show resolved
Hide resolved
PureWeen
reviewed
Jun 10, 2025
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29882.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Jun 10, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in MAUI SDK Ongoing
rmarinho
pushed a commit
that referenced
this pull request
Jun 24, 2025
…dler (#29887) * Add null check for ItemsSource before Selection/ Deselection * Add an UI test * Update null check * more null checks * Update namespace * update namespace again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Added null checks for ItemsSource in all platform and xplat selection/deselection methods.
This fix is intended as a patch to prevent the crash in SR8.
A follow-up PR will address the root cause.
Issues Fixed
Contributes to #29882