[Testing] Re-Fix for flaky UITests RotatingCollectionViewWithHTMLShouldNotHangOrCrash in CI that occasionally fails #30239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
ghost
added
ghost
marked this pull request as ready for review
There was a problem hiding this comment.
Pull Request Overview
This PR enhances UI test stability by eliminating arbitrary delays in a flaky test and introducing a retry helper for tapping elements until the UI is ready. Key changes include:
- Replaced
Thread.SleepwithApp.WaitForElementinIssue8870.csto synchronize on UI readiness. - Introduced
TapWithRetriesUntilElementReadyandIsElementVisibleinHelperExtensions.csfor more robust element interactions. - Modernized the namespace declaration style in the test file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/TestUtils/src/UITest.Appium/HelperExtensions.cs | Added TapWithRetriesUntilElementReady and IsElementVisible to handle flaky taps. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.cs | Swapped out Thread.Sleep for App.WaitForElement and used the new retry tap helper; applied semicolon namespace syntax. |
Comments suppressed due to low confidence (1)
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:2569
- Add automated tests for
TapWithRetriesUntilElementReady(andIsElementVisible) in TestCases.Shared.Tests and ensure corresponding UI apps in TestCases.HostApp validate its behavior; this will guarantee the new helper is exercised and prevent regressions.
public static bool TapWithRetriesUntilElementReady(this IApp app, string elementToTap, string elementToWaitFor,
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
Jun 27, 2025
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Jun 27, 2025
…ldNotHangOrCrash in CI that occasionally fails (dotnet#30239) * fixed flaky test 8870 * Update src/TestUtils/src/UITest.Appium/HelperExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces improvements to test reliability and code clarity in the
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.csfile and adds a new helper method to enhance UI testing functionality insrc/TestUtils/src/UITest.Appium/HelperExtensions.cs. The most significant changes include replacingThread.SleepwithApp.WaitForElementfor better synchronization, adding a new helper methodTapWithRetriesUntilElementReadyto handle UI interactions more robustly, and adopting a modern namespace declaration style.Improvements to test reliability:
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.cs: ReplacedThread.Sleepcalls withApp.WaitForElementto ensure synchronization with the UI state during orientation changes. This improves test reliability by waiting for elements to be ready instead of relying on arbitrary delays.src/TestUtils/src/UITest.Appium/HelperExtensions.cs: Added a new helper methodTapWithRetriesUntilElementReady, which retries tapping an element until a target element becomes interactable or the retry limit is reached. This addresses cases where elements may appear but are not immediately ready for interaction.Code clarity improvements:
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.cs: Adopted a modern namespace declaration style by removing braces and switching to thenamespacesemicolon syntax. This simplifies the code structure and aligns with current C# conventions.