-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Better MSBuild log messages in DevOps #30281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the MSBuild logging experience in Azure DevOps by forwarding logger arguments to MSBuild commands and ensuring errors and warnings are forwarded correctly. The key changes include a modification to the IMauiContext public API and updates to the Cake build script to append the forwarding logger argument.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/Core/src/IMauiContext.cs | Changed the property accessor from "get" to "gets" in the public interface, which appears unintended. |
eng/cake/dotnet.cake | Added logic to retrieve and append the MSBuild forwarding logger argument for improved logging in DevOps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build failing
probably on purpose :-)
Mainly just requesting changes to shift this off approved
Failures unrelated. |
* Use a better logger for Azure DevOps * Update dotnet.cake * Update IMauiContext.cs
* Use a better logger for Azure DevOps * Update dotnet.cake * Update IMauiContext.cs
Description of Change
Use the forwarding logger to forward errors and warnings to AzDo.