KEMBAR78
Better MSBuild log messages in DevOps by mattleibow · Pull Request #30281 · dotnet/maui · GitHub
Skip to content

Conversation

mattleibow
Copy link
Member

Description of Change

Use the forwarding logger to forward errors and warnings to AzDo.

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 15:57
@mattleibow mattleibow requested a review from a team as a code owner June 27, 2025 15:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the MSBuild logging experience in Azure DevOps by forwarding logger arguments to MSBuild commands and ensuring errors and warnings are forwarded correctly. The key changes include a modification to the IMauiContext public API and updates to the Cake build script to append the forwarding logger argument.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Core/src/IMauiContext.cs Changed the property accessor from "get" to "gets" in the public interface, which appears unintended.
eng/cake/dotnet.cake Added logic to retrieve and append the MSBuild forwarding logger argument for improved logging in DevOps.

rmarinho
rmarinho previously approved these changes Jun 28, 2025
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failing

probably on purpose :-)
Mainly just requesting changes to shift this off approved

@mattleibow mattleibow self-assigned this Jul 26, 2025
@PureWeen PureWeen added platform/macos macOS / Mac Catalyst platform/windows platform/android platform/ios area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions labels Aug 7, 2025
@mattleibow
Copy link
Member Author

Failures unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions platform/android platform/ios platform/macos macOS / Mac Catalyst platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants