KEMBAR78
Extract enhanced copilot instructions from PR #30300 by Copilot · Pull Request #30304 · dotnet/maui · GitHub
Skip to content

Extract enhanced copilot instructions from PR #30300 #30304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2025
Merged

Extract enhanced copilot instructions from PR #30300 #30304

merged 5 commits into from
Jun 30, 2025

Conversation

Copy link
Contributor

Copilot AI commented Jun 29, 2025 •
edited
Loading

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description

This PR extracts and applies the enhanced copilot instructions from PR #30300 to improve guidance for coding agents working on the .NET MAUI repository.

Changes Made

Enhanced "Handling Existing PRs for Assigned Issues" Section

The key improvements extracted from PR #30300 include:

  1. Added critical requirement warning with 🚨 emoji for maximum visibility:

    🚨 CRITICAL REQUIREMENT: Always check for existing PRs first before implementing any solution.

  2. New mandatory first step that requires searching for existing PRs before starting any implementation work:

    1. FIRST: Search for existing PRs - Before starting any implementation, always search for open PRs that address the same issue using GitHub search or issue links

  3. Better organization by moving the section to appear earlier in the document (right after "Contribution Guidelines" header) for improved visibility

  4. Enhanced step-by-step guidance with steps renumbered 1-10 for clarity and better structure

  5. Removed duplicate content by consolidating the old section that appeared later in the document

Benefits

These enhanced instructions help ensure that:

  • Coding agents follow proper workflow and check for existing work first
  • Duplicate effort is avoided when working on issues that already have open PRs
  • There's clear, actionable guidance on how to handle existing PRs appropriately
  • The critical requirement is prominently displayed for maximum impact

Testing

The changes have been validated to ensure:

Fixes #30303.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@PureWeen
Extract enhanced copilot instructions from PR #30300
b20b193 
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot AI changed the title [WIP] Extract copilot instructions from https://github.com/dotnet/maui/pull/30300 Extract enhanced copilot instructions from PR #30300 Jun 29, 2025
Copilot AI requested a review from PureWeen June 29, 2025 17:48
Copilot finished work on behalf of PureWeen June 29, 2025 17:48
@PureWeen
Copy link
Member

Update the instructions so that you will always come up with your own solution first without looking at other PRs, then you will look for open PRs and compare what you came up to existing PRs. Once you pick which option you like better, always make sure to report on why you didn't go with the other solutions

@PureWeen
Update workflow to develop solution first, then compare with existing…
9d666fc 
… PRs

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 29, 2025

Update the instructions so that you will always come up with your own solution first without looking at other PRs, then you will look for open PRs and compare what you came up to existing PRs. Once yo...

Updated the workflow as requested. The instructions now require developing your own solution first without looking at existing PRs, then searching for and comparing with existing PRs, and always documenting why you chose one approach over others. The critical requirement warning has been updated to reflect this new workflow. Commit: 6f887b02

Copilot finished work on behalf of PureWeen June 29, 2025 18:04
@PureWeen PureWeen marked this pull request as ready for review June 29, 2025 18:05
@Copilot Copilot AI review requested due to automatic review settings June 29, 2025 18:05
@PureWeen PureWeen requested a review from a team as a code owner June 29, 2025 18:05
Copilot
Copilot AI reviewed Jun 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts and applies enhanced instructions for handling existing pull requests for assigned issues in the .NET MAUI repository to ensure contributors follow a clear, structured workflow.

  • Introduces a new "Handling Existing PRs for Assigned Issues" section with a critical requirement warning.
  • Reorganizes the instructions so that the new guidelines appear immediately after the "Contribution Guidelines" header.
  • Removes duplicate older guidance in favor of a comprehensive, step-by-step approach.
Comments suppressed due to low confidence (1)

.github/copilot-instructions.md:157

  • [nitpick] Consider clarifying the rationale behind 'develop your own solution first' to prevent potential misinterpretation by contributors who might otherwise prioritize independent work over collaborative review.
**🚨 CRITICAL REQUIREMENT: Always develop your own solution first, then compare with existing PRs.**

@PureWeen
Copy link
Member

If you like the other solution more pull those changes into your PR and then find areas to improve and add tests

@PureWeen
Update step 8 to explicitly mention pulling existing PR changes and i…
edbbf2f 
…mproving them

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 29, 2025

If you like the other solution more pull those changes into your PR and then find areas to improve and add tests

Updated step 8 to explicitly mention pulling existing PR changes when you prefer them and finding areas to improve and add tests. Commit: 07fe5be

Copilot finished work on behalf of PureWeen June 29, 2025 18:27
PureWeen
PureWeen reviewed Jun 29, 2025
View reviewed changes
@PureWeen
Remove duplicate step 10 as requested in review feedback
d7b9150 
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot AI requested a review from PureWeen June 29, 2025 18:40
Copilot finished work on behalf of PureWeen June 29, 2025 18:40
@PureWeen PureWeen merged commit b87c380 into main Jun 30, 2025
1 check passed
@PureWeen PureWeen deleted the copilot/fix-30303 branch June 30, 2025 15:55
PureWeen added a commit that referenced this pull request Jul 1, 2025
@PureWeen
Extract enhanced copilot instructions from PR #30300 (#30304)
3e687cb 
* Initial plan

* Extract enhanced copilot instructions from PR #30300

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

* Update workflow to develop solution first, then compare with existing PRs

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

* Update step 8 to explicitly mention pulling existing PR changes and improving them

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

* Remove duplicate step 10 as requested in review feedback

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Tamilarasan-Paranthaman pushed a commit to Tamilarasan-Paranthaman/maui that referenced this pull request Jul 4, 2025
@PureWeen @Tamilarasan-Paranthaman
Extract enhanced copilot instructions from PR dotnet#30300 (dotnet#30304
ab8afcc 
)

* Initial plan

* Extract enhanced copilot instructions from PR dotnet#30300

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

* Update workflow to develop solution first, then compare with existing PRs

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

* Update step 8 to explicitly mention pulling existing PR changes and improving them

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

* Remove duplicate step 10 as requested in review feedback

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
@PureWeen PureWeen added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@mattleibow mattleibow mattleibow approved these changes

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

@PureWeen PureWeen

Copilot code review Copilot

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract copilot instructions from https://github.com/dotnet/maui/pull/30300

3 participants

@PureWeen @mattleibow