Fixed the SafeArea branch test case failures issues #30622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
Ahamed-Ali
requested review from
jfversluis and
jsuarezruiz
and removed request for
a team
|
/azp run MAUI-UITests-public |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
PureWeen
merged commit 0443393
into
dotnet:PureWeen/safe-area-fixes-ios
2 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
* Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac
PureWeen
pushed a commit
that referenced
this pull request
Jul 15, 2025
* Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac
PureWeen
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac
PureWeen
added a commit
that referenced
this pull request
Jul 17, 2025
…eProperlyOnCollectionView (#30682) * Fix SafeArea management on iOS * Fixed the SafeArea branch test case failures issues (#30622) * Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac * Enhance CrossPlatformArrange method to support safe area adjustments and improve RTL layout handling * - add images and fix naming * - additional image updates * - add comments * fix update. --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>
PureWeen
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac
PureWeen
added a commit
that referenced
this pull request
Jul 17, 2025
…eProperlyOnCollectionView (#30682) * Fix SafeArea management on iOS * Fixed the SafeArea branch test case failures issues (#30622) * Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac * Enhance CrossPlatformArrange method to support safe area adjustments and improve RTL layout handling * - add images and fix naming * - additional image updates * - add comments * fix update. --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>
PureWeen
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac
PureWeen
added a commit
that referenced
this pull request
Jul 17, 2025
…eProperlyOnCollectionView (#30682) * Fix SafeArea management on iOS * Fixed the SafeArea branch test case failures issues (#30622) * Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac * Enhance CrossPlatformArrange method to support safe area adjustments and improve RTL layout handling * - add images and fix naming * - additional image updates * - add comments * fix update. --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
…eProperlyOnCollectionView (#30682) * Fix SafeArea management on iOS * Fixed the SafeArea branch test case failures issues (#30622) * Fixed the SafeArea test case issues and 22417(mac) main issue * Removed the Fails condition on Mac * Enhance CrossPlatformArrange method to support safe area adjustments and improve RTL layout handling * - add images and fix naming * - additional image updates * - add comments * fix update. --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Test failures
Description of Change
Arranged the bounds before scheduling the second layout pass. This ensures the native view is aware of the correct bounds and can adjust its layout accordingly. This helps resolve test failures related to 22417 (iOS), 7678, and 25192.
Ensure the size never exceeds the constraints.
(i.e) In the 22417 test sample on Mac (CarouselView1), if widthConstraint is 1085, it becomes 1512 after the SizeThatFits call inside the ViewHandlerExtensions.iOS, causing the view's width to appear larger on Mac.
On iOS, the value remains correct — for example, if widthConstraint is 375, SizeThatFits also returns 375.
Tested the behaviour in the following platforms
Screenshot
Before fix
7678Issue.mov
22417iOSIssue.mov
25192Issue.mov
After fix
22417MacFix.mov
7678Fixed.mov
22417iOSFixed.mov
25192Fixed.mov