Add CornerRadius parameter order notes #30930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds important clarification notes to properties that use the CornerRadius type, addressing a documentation gap where the parameter order differs from other frameworks. The main goal is to inform developers that corner radius values should be specified in the order: top left, top right, bottom left, and bottom right.
Key changes include:
- Addition of parameter order notes to all
CornerRadiusproperties across multiple UI components - Migration of XML documentation from external files to inline source code comments
- Modernization of code structure with file-scoped namespaces
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Controls/src/Core/Shapes/RoundRectangleGeometry.cs |
Replaced XML includes with inline documentation and added corner radius parameter order notes |
src/Controls/src/Core/Shapes/RoundRectangle.cs |
Added inline documentation with corner radius parameter order clarification |
src/Controls/src/Core/ICornerElement.cs |
Converted to file-scoped namespace and added comprehensive interface documentation with parameter order notes |
src/Controls/src/Core/BoxView/BoxView.cs |
Replaced XML includes with inline documentation and added corner radius parameter order notes |
src/Controls/docs/Microsoft.Maui.Controls/BoxView.xml |
Removed external XML documentation file (content moved to source) |
src/Controls/docs/Microsoft.Maui.Controls.Shapes/RoundRectangleGeometry.xml |
Removed external XML documentation file (content moved to source) |
PureWeen
approved these changes
Aug 2, 2025
|
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
Aug 12, 2025
rmarinho
pushed a commit
that referenced
this pull request
Aug 13, 2025
This was referenced Aug 15, 2025
Closed
Bump Microsoft.AspNetCore.Components.WebView.Maui from 9.0.90 to 9.0.100
ILoveDotNet/ilovedotnet#467
Merged
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notes to properties with the
CornerRadiustype. The order of declaring the parameter values is a bit out of line with other frameworks. That is hard to fix (not from a technical standpoint, but from a breaking change perspective) so this is our "fix" for now. Also see: #13136 (comment)Additionally, minor code improvements: move XML into source, file-scope namespace, etc.
Fixes #13136