Fix pan and pinch gesture completion on Windows #31123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@jeremy-visionaid! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@MartyIX Oh, I realize now that the panning is supposed to continue running even when the cursor exits the control. I'll have another go... |
jeremy-visionaid
force-pushed
the
pinch-gesture-completion-fix
branch
from
ce96b38 to
dfef008
Compare
jeremy-visionaid
force-pushed
the
pinch-gesture-completion-fix
branch
from
dfef008 to
0aa3b46
Compare
|
OK, this should now fix up a few corner cases:
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Aug 21, 2025
PureWeen
pushed a commit
that referenced
this pull request
Sep 5, 2025
Remove unnecessary guards in GesturePlatformManager Fix Windows pan and pinch gesture completion Fixes: #31033
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Fixes various issues with completion events not being received and pinch gestures not operating correctly on Windows.
Issues Fixed
Fixes #31033