[Windows] Test inclusion for the PointerGestureRecognizer issue in MultiWindow. #31143
Conversation
dotnet-policy-service
bot
added
community ✨
There was a problem hiding this comment.
Pull Request Overview
This PR adds Windows-specific UI test coverage for a PointerGestureRecognizer issue that occurs when multiple windows are open. The test verifies that pointer enter and exit events are correctly handled after opening, minimizing, and interacting with windows.
- Implements the required two-part test structure with both HostApp UI and automated test components
- Adds Windows-specific multi-window management functionality using native Windows APIs
- Validates pointer gesture behavior in a multi-window scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/Issue30536.cs | Creates UI test page with multi-window functionality and pointer gesture tracking |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30536.cs | Implements automated NUnit test to validate pointer gesture behavior across windows |
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
| public class Issue30536 : _IssuesUITest |
There was a problem hiding this comment.
The test creates a new window and then closes it, but there's no verification that the window was successfully closed or that the UI state was properly restored. Consider adding assertions to verify the window lifecycle operations completed successfully.
Copilot uses AI. Check for mistakes.
| private void MinimizeWindow(Window window) | ||
| { | ||
| #if WINDOWS | ||
| if (window.Handler?.PlatformView is Microsoft.UI.Xaml.Window win) |
There was a problem hiding this comment.
The MinimizeWindow method uses unsafe casting without error handling. If the cast fails or the PlatformView is null, the minimize operation will silently fail, which could cause test failures that are difficult to debug.
Copilot uses AI. Check for mistakes.
| { | ||
| // Get window handle directly from MAUI's platform view | ||
| var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(win); | ||
| ShowWindow(hwnd, SW_MINIMIZE); |
There was a problem hiding this comment.
The GetWindowHandle call could potentially return IntPtr.Zero if the window handle is invalid. Consider adding validation to ensure the handle is valid before calling ShowWindow.
| ShowWindow(hwnd, SW_MINIMIZE); | |
| if (hwnd != IntPtr.Zero) | |
| { | |
| ShowWindow(hwnd, SW_MINIMIZE); | |
| } |
Copilot uses AI. Check for mistakes.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues
…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues
…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues
…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues
…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues
4 participants
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Included the test for the PointerGestureRecognizer issue in windows
#30537