Radio Button Null Selection Fix #31175
Conversation
@dotnet-policy-service agree |
src/Controls/samples/Controls.Sample/ViewModels/RadioButtonNullSelectionViewModel.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
I noticed. Some observations:
- Edit: If I change the groupname to "bar", ity passes.
@jfversluis I've been trying to debug, but would appreciate some wisdom if it's available. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31175 in repo dotnet/maui |
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jfversluis How do I run these UI tests locally? I can't seem to figure out how to run them. |
I simply run |
Thank, I was able to somewhat figure it out. @jfversluis, I have made a change but it feels... hacky... so if it's not appropriate, I'll take some time to think of a different solution. |
|
@jfversluis I have have used the more conventional way of ensuring the value is "coerced" to itself if set to null. Can the test be run again? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jfversluis Forgive my ignorance here, but it looks like the failures are all simulators that failed to start??? Is that correct??? Or am I missing something and there's something I need to change? |
jfversluis
force-pushed
the
fix-19437
branch
from
cdebed7 to
8adfcdd
Compare
|
Thank you for your contribution! |
* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <EBallantyne@acceleratedsystems.com>
* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <EBallantyne@acceleratedsystems.com>
* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <EBallantyne@acceleratedsystems.com>
* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <EBallantyne@acceleratedsystems.com>
* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <EBallantyne@acceleratedsystems.com>
3 participants
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Allows Radio Button group controller Value to be set to null. This can clear radio button(s) that have been selected.
Issues Fixed
Fixes #19437