[release/10.0.1xx-rc1] Use ToLowerInvariant().Contains(...) for .NET Framework
#31354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mattleibow
changed the title
ToLowerInvariant().Contains(...) for .NET Framework
mattleibow
approved these changes
Aug 26, 2025
rmarinho
pushed a commit
that referenced
this pull request
Aug 31, 2025
…ns(...) for .NET Framework [release/10.0.1xx-rc1] Use ToLowerInvariant().Contains(...) for .NET Framework ([#31354](#31354)) Co-authored-by: Stephane Delcroix <stephane@delcroix.org> ---- #### AI description (iteration 1) #### PR Classification This pull request implements a code cleanup by simplifying case-insensitive string comparisons. #### PR Summary The changes update the conditions in the Maui Controls targets file, replacing multiple explicit string comparison overloads with a cleaner approach using ToLowerInvariant().Contains(...). - `src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.targets`: Updated conditions for `<_MauiXaml_SG>`, `<_MauiXaml_RT>`, and `<_MauiXaml_XC>` to use ToLowerInvariant().Contains(...) instead of Contains(..., StringComparison.OrdinalIgnoreCase). <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #31353 to release/10.0.1xx-rc1
/cc @jfversluis @StephaneDelcroix