[templates] add Android INTERNET permission #6673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#6576 Debug builds on Android automatically add the `INTERNET` permission, because otherwise debugging wouldn't work! This definitely adds some confusion if you switch to a `Release` build and start getting exceptions in your `HttpClient` calls. We should just add the `INTERNET` premission to the Android templates, as nearly every modern app will use the internet. Customers can simply remove the permission if they don't want it.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Apr 29, 2022
Context: dotnet/maui#6576 Context: dotnet/maui#6673 Debug builds on Android automatically add the `INTERNET` permission, because otherwise debugging wouldn't work! This definitely adds some confusion if you switch to a `Release` build and start getting exceptions in your `HttpClient` calls. We should just add the `INTERNET` premission to the Android templates, as nearly every modern app will use the internet. Customers can simply remove the permission if they don't want it.
jonathanpeppers
added
area-templates
jamesmontemagno
approved these changes
Apr 29, 2022
mattleibow
approved these changes
Apr 29, 2022
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Apr 29, 2022
Context: dotnet/maui#6576 Context: dotnet/maui#6673 Debug builds on Android automatically add the `INTERNET` permission, because otherwise debugging wouldn't work! This definitely adds some confusion if you switch to a `Release` build and start getting exceptions in your `HttpClient` calls. We should just add the `INTERNET` premission to the Android templates, as nearly every modern app will use the internet. Customers can simply remove the permission if they don't want it.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Apr 29, 2022
Context: dotnet/maui#6576 Context: dotnet/maui#6673 Debug builds on Android automatically add the `INTERNET` permission, because otherwise debugging wouldn't work! This definitely adds some confusion if you switch to a `Release` build and start getting exceptions in your `HttpClient` calls. We should just add the `INTERNET` premission to the Android templates, as nearly every modern app will use the internet. Customers can simply remove the permission if they don't want it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6576
Debug builds on Android automatically add the
INTERNETpermission,because otherwise debugging wouldn't work! This definitely adds some
confusion if you switch to a
Releasebuild and start gettingexceptions in your
HttpClientcalls.We should just add the
INTERNETpremission to the Android templates,as nearly every modern app will use the internet. Customers can simply
remove the permission if they don't want it.