KEMBAR78
Merge 'main' into ParamsCollections by AlekseyTs · Pull Request #72497 · dotnet/roslyn · GitHub
Skip to content

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

chsienki and others added 15 commits March 8, 2024 14:15
* Add method to expose generator run result on the project
* Expose run results to razor
[main] Update dependencies from dotnet/arcade
…#72303)

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240227.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24127.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240227.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24127.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240227.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24127.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240301.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24151.1

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240301.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24151.1

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240301.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24151.1

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240304.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24154.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240304.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24154.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240304.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24154.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240304.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24154.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240308.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24158.2

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240308.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24112.1 -> To Version 9.0.0-alpha.1.24158.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Use AsyncBatchingWorkQueue instead of TaskQueue
Semantic snippets: Do not generate async write in `cw` snippet
)

 Reduce closure allocations associated with AsyncLazy usage

This was noticed while looking at speedometer profiles. This class is used in several high traffic areas, and the current AsyncLazy design doesn't allow usage in a way that prevents closure allocations. This PR adds the "arg" usage pattern to AsyncLazy such that funcs passed to AsyncLazy can take advantage of the arg infrastructure to avoid closure allocations.

This is done by changing AsyncLazy<T> to be an abstract class with a single derivation that caches the argument data. Users still declare their type to be AsyncLazy<T>, but the AsyncLazy.Create methods have been altered to have optional overloads that take in data.
@AlekseyTs AlekseyTs requested review from a team as code owners March 12, 2024 04:09
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 12, 2024
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @333fred, @dotnet/roslyn-compiler Need a sign-off for a merge from main

@AlekseyTs AlekseyTs enabled auto-merge March 12, 2024 05:20
@jcouv
Copy link
Member

jcouv commented Mar 12, 2024

The commit list seems strange, with commits from 2022. Are those expected?
Never mind, this is merging into the feature branch... I thought this was merging back to main.

@AlekseyTs AlekseyTs merged commit bf22912 into dotnet:features/ParamsCollections Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.