Use BoundsCheckNoThrow assertion in optAssertionProp_RangeProperties #102089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
@AndyAyersMS @jakobbotsch @dotnet/jit-contrib PTAL |
tannergooding
approved these changes
May 10, 2024
jakobbotsch
approved these changes
May 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102088
; Method Bench:Test(System.Span`1[int],int):int:this (FullOpts) sub rsp, 40 cmp r8d, dword ptr [rdx+0x08] jae SHORT G_M45212_IG04 mov rax, bword ptr [rdx] mov ecx, r8d - mov edx, r8d - sar edx, 31 - and edx, 7 - add edx, r8d - and edx, -8 - sub r8d, edx + and r8d, 7 add r8d, dword ptr [rax+4*rcx] mov eax, r8d add rsp, 40 ret G_M45212_IG04: call CORINFO_HELP_RNGCHKFAIL int3 -; Total bytes of code: 52 +; Total bytes of code: 38