KEMBAR78
Normalize the creation of simd comparison nodes and give basic constant folding support by tannergooding · Pull Request #104215 · dotnet/runtime · GitHub
Skip to content

Normalize the creation of simd comparison nodes and give basic constant folding support #104215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2024
Merged

Normalize the creation of simd comparison nodes and give basic constant folding support #104215

merged 5 commits into from
Jul 3, 2024
+816 −31

Conversation

@tannergooding
Copy link
Member

This ensures that SIMD comparison nodes are consistently created and gives basic constant folding support to them.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 30, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 1, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 1, 2024
Closed
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, this should also be ready for review.

It ensures that SIMD Compare nodes are consistently created and adds the basic recognition of them to HWOperGet which allows them to plug into the existing binary constant folding support.

There's some nice codegen wins, which can be improved further in a follow up PR by ensuring that op_Equality and op_Inequality are also handled. These require special handling, however, since they produce bool instead of a SIMD result.

@build-analysis build-analysis bot mentioned this pull request Jul 1, 2024
Open
kunalspathak
kunalspathak approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codegen diffs looks great. LGTM

@tannergooding tannergooding merged commit 1757a02 into dotnet:main Jul 3, 2024
@tannergooding tannergooding deleted the morph-simd-cmp branch July 3, 2024 00:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tannergooding tannergooding

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannergooding @kunalspathak