KEMBAR78
avoid alpn allocation on windows by wfurt · Pull Request #74619 · dotnet/runtime · GitHub
Skip to content

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 26, 2022

follow up on #69098. Removes buffer allocations for common case. Pre-computes common sets.

contributes to #68951

@wfurt wfurt added this to the 8.0.0 milestone Aug 26, 2022
@wfurt wfurt requested a review from a team August 26, 2022 02:31
@wfurt wfurt self-assigned this Aug 26, 2022
@ghost
Copy link

ghost commented Aug 26, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

follow up on #69098. Removes buffer allocations for common case. Pre-computes common sets.

contributes to #68951

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, os-windows

Milestone: 8.0.0

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@wfurt wfurt marked this pull request as draft October 25, 2022 16:05
@wfurt wfurt marked this pull request as ready for review November 8, 2022 19:31
@karelz
Copy link
Member

karelz commented Nov 15, 2022

@stephentoub can you please review (there are updates here). Thanks!

@wfurt
Copy link
Member Author

wfurt commented Nov 22, 2022

WASM failures are unrelated.

@wfurt wfurt merged commit a8e2b6e into dotnet:main Nov 22, 2022
@wfurt wfurt deleted the alpnWin branch November 22, 2022 18:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants