Avoid allocations in ClientWebSocket.ConnectAsync in the common case #75025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
For the following test case using var cws = new ClientWebSocket();
await cws.ConnectAsync(uri, CancellationToken.None);This saves about ~10% of the allocations (20.164 => 17.940). Before
After
|
stephentoub
reviewed
Sep 2, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Managed.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 2, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Managed.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Sep 2, 2022
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Outerloop failures are still #74468 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientWebSocketOptions.Proxyis set by default, so the shared handler wasn't being used in the common case.This PR adds a second handler field that's used when a default proxy is requested.
While we're changing this code, I also changed it to store an
HttpMessageInvokerinstead ofSocketsHttpHandler.For the following test case
This saves about ~10% of the allocations (20.164 => 17.940).
Before
After