KEMBAR78
Add HashTo/GetCurrentHashAs{UInt32/64} methods by stephentoub · Pull Request #78075 · dotnet/runtime · GitHub
Skip to content

Add HashTo/GetCurrentHashAs{UInt32/64} methods #78075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2022
Merged

Add HashTo/GetCurrentHashAs{UInt32/64} methods #78075

merged 3 commits into from
Nov 16, 2022

Conversation

@stephentoub
Copy link
Member

Fixes #76279

@stephentoub stephentoub requested a review from bartonjs November 8, 2022 23:05
@ghost
Copy link

ghost commented Nov 8, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@build-analysis build-analysis bot mentioned this pull request Nov 9, 2022
Closed
@xoofx xoofx mentioned this pull request Nov 12, 2022
Merged
@stephentoub
Copy link
Member Author

@bartonjs, mind taking a look? Thanks.

bartonjs
bartonjs approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Based on the conversation I had with @GrabYourPitchforks when the API was proposed, and our assertion of GetCurrentHashCode() being king, I'd expect the endianness comments in all of the integer-based values (as a remarks remark or just as part of the returns ("Returns the [whatever algorithm] hash code using little-endian byte ordering."), maybe with a <seealso cref="GetCurrentHash()" />.

@build-analysis build-analysis bot mentioned this pull request Nov 14, 2022
Open
@stephentoub
Copy link
Member Author

Thanks for the review.

@stephentoub stephentoub merged commit 9bddd01 into dotnet:main Nov 16, 2022
@stephentoub stephentoub deleted the simplehashing branch November 16, 2022 11:12
@uweigand
Copy link
Contributor

Hi @stephentoub , the new test cases added here all fail on s390x, from the logs it looks like an obvious endian problem:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-5428a61833d54fffa2/System.IO.Hashing.Tests/1/console.0c4ec733.log?helixlogtype=result

    System.IO.Hashing.Tests.Crc64Tests.VerifyHashToUInt64(testCase: One) [FAIL]
      Assert.Equal() Failure
                ↓ (pos 0)
      Expected: 42F0E1EBA9EA3693
      Actual:   9336EAA9EBE1F042
                ↑ (pos 0)

etc.

@stephentoub stephentoub mentioned this pull request Dec 2, 2022
Merged
akoeplinger pushed a commit that referenced this pull request Dec 2, 2022
@stephentoub
Fix NonCryptoHashTestDriver.AssertEqualHashNumber for big endian (#79135
47e26b2 
)

Fix #78075 (comment)
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees

No one assigned

Labels

area-System.IO new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Simple one-shot hashing methods that produce the relevant type

3 participants

@stephentoub @uweigand @bartonjs