Shave ~90K off regex in native aot #80884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ifdef out some code only used in debug but that included a static which was rooting some of the methods - Avoid using a ValueTuple`7 as a dictionary key and instead use a custom struct - Remove a Sort call that was leftover from debugging but isn't necessary for correctness or performance - Avoid using a `HashSet<UnicodeCategory>` when a `bool[30]` would suffice - Avoid a generic instantation for a `Dictionary<enum,object,object>` by changing it to `Dictionary<int,object,object>`, which we already use in the same type
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue Details
This: using System.Text.RegularExpressions;
internal class Program
{
static void Main()
{
Console.WriteLine(new Regex("a", RegexOptions.CultureInvariant | RegexOptions.IgnoreCase).IsMatch("abc"));
}
}published for Windows x64 native aot drops from 3618K to 3529K.
|
eerhardt
approved these changes
Jan 19, 2023
.../System.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/CharSetSolver.cs
Outdated
Show resolved
Hide resolved
...em.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/RegexNodeConverter.cs
Outdated
Show resolved
Hide resolved
Sounds like #76513? |
marek-safar
added
the
size-reduction
|
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue Details
This: using System.Text.RegularExpressions;
internal class Program
{
static void Main()
{
Console.WriteLine(new Regex("a", RegexOptions.CultureInvariant | RegexOptions.IgnoreCase).IsMatch("abc"));
}
}published for Windows x64 native aot drops from 3618K to 3529K.
|
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
* Shave ~100K off regex in native aot - ifdef out some code only used in debug but that included a static which was rooting some of the methods - Avoid using a ValueTuple`7 as a dictionary key and instead use a custom struct - Remove a Sort call that was leftover from debugging but isn't necessary for correctness or performance - Avoid using a `HashSet<UnicodeCategory>` when a `bool[30]` would suffice - Avoid a generic instantation for a `Dictionary<enum,object,object>` by changing it to `Dictionary<int,object,object>`, which we already use in the same type * Address PR feedback
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashSet<UnicodeCategory>when abool[30]would sufficeDictionary<enum,object,object>by changing it toDictionary<int,object,object>, which we already use in the same typeThis:
published for Windows x64 native aot drops from 3618K to 3529K.