[JIT] ARM64 - Optimize x < 0 and x >= 0
#83176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAddresses the first case of #43440 As for handling
|
TIHan
changed the title
x < 0 and x >= 0
This was referenced Mar 10, 2023
5 tasks
jakobbotsch
reviewed
Mar 14, 2023
jakobbotsch
reviewed
Mar 14, 2023
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
jakobbotsch
approved these changes
Mar 14, 2023
|
I'm going to do another round for this optimization, filed #83562 to track it. Therefore, I will go ahead and merge this one. |
This was referenced Mar 23, 2023
Closed
Closed
Closed
3 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#43440
As for handling
GT_GE, I do not think it is worth doing the optimization in the non-conditional case. It would requirenegand alsrwhich I believe would be slower than just thecmpandcset. According to A78, the pair ofcmpandcsetinstructions are accelerated through instruction fusion - so it's probably only worth replacing them if we can do it in just one instruction.Acceptance Criteria
x < 0andx >= 0#83562