KEMBAR78
Use CollectionsMarshal.SetCount in LINQ to deduplicate ToArray/ToList implementations by stephentoub · Pull Request #85288 · dotnet/runtime · GitHub
Skip to content

Conversation

@stephentoub
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: -
Labels:

area-System.Linq

Milestone: -

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

The test was implemented using ToList, and `List<T>` serialization serializes out its version field.  As a result, because we're now optimizing creation and not incrementing the version as much in ToList, the blob didn't match.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants