KEMBAR78
JIT: Unroll newly recognized loops by jakobbotsch · Pull Request #96752 · dotnet/runtime · GitHub
Skip to content

JIT: Unroll newly recognized loops #96752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

JIT: Unroll newly recognized loops #96752

merged 1 commit into from
Jan 12, 2024

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Jan 10, 2024 •
edited
Loading

No description provided.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 10, 2024
@ghost ghost assigned jakobbotsch Jan 10, 2024
@ghost
Copy link

ghost commented Jan 10, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on #96751

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this pull request Jan 10, 2024
Closed
21 tasks
@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 11, 2024
Closed
@jakobbotsch jakobbotsch marked this pull request as ready for review January 11, 2024 12:36
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @BruceForstall

Diffs. Not too many cases. We may get some more when we fix

runtime/src/coreclr/jit/flowgraph.cpp

Lines 4959 to 4962 in 8f79b66

// TODO-Quirk: For backwards compatibility always try the lexically
// bottom-most block for the loop variable.
BasicBlock* bottom = GetLexicallyBottomMostBlock();
JITDUMP(" Bottom = " FMT_BB "\n", bottom->bbNum);

@jakobbotsch jakobbotsch merged commit dfbda9a into dotnet:main Jan 12, 2024
@jakobbotsch jakobbotsch deleted the unroll-new-loops branch January 12, 2024 13:04
This was referenced Jan 16, 2024
Open
Open
@DrewScoggins DrewScoggins mentioned this pull request Jan 16, 2024
Closed
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@jakobbotsch @tmds
JIT: Unroll newly recognized loops (dotnet#96752)
6e5948b
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch @BruceForstall