Reduce defensive copying in PublicKey #97108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsThe bypasses a few more defensive copies in
Likewise for
|
filipnavara
approved these changes
Jan 17, 2024
bartonjs
approved these changes
Jan 17, 2024
This was referenced Jan 18, 2024
stephentoub
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bypasses a few more defensive copies in
PublicKey.AsnEncodedData(AsnEncodedData)makes a defensive copy of the data for itself, which the constructor ofPublicKeyuses. However, there are a few factory methods inPublicKeythat create anAsnEncodedDatasolely for the purpose of transferring toPublicKey. In that circumstance, we can bypass the copy since the creation of theAsnEncodedDataalready made the defensive copy.Likewise for
X509Certificate2.PublicKey. This shaves several hundred bytes in allocation, scaling with the key size.