fix: WCO occlusion of DevTools #35209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Aug 9, 2022
MarshallOfSound
approved these changes
Aug 9, 2022
codebytere
force-pushed
the
match-chrome-wco-devtools
branch
from
2743e4f to
fac1fb9
Compare
VerteDinde
approved these changes
Aug 9, 2022
codebytere
force-pushed
the
match-chrome-wco-devtools
branch
from
fac1fb9 to
f35390b
Compare
|
Release Notes Persisted
|
This was referenced Aug 11, 2022
|
I have automatically backported this PR to "18-x-y", please check out #35307 |
|
I have automatically backported this PR to "19-x-y", please check out #35308 |
|
I have automatically backported this PR to "20-x-y", please check out #35309 |
2 tasks
|
/trop run backport-to 21-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "21-x-y", please check out #35688 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
3 tasks
3 tasks
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
|
So when the user manually dock the devtool to the right side, it would still be occluded (see microsoft/vscode#168454 (comment)). Is there any plan to actually fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34129.
This change matches Chromium behavior for WCO by opening DevTools in detached mode if WCO is enabled.
This prevents the DevTools from being occluded and becoming semi-unusable.
Before
After
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where WCO could occlude DevTools opened in any non-detached mode.