fix: BroadcastChannel initialization location
#37421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-broadcast-channel
branch
from
708c61c to
e4d0061
Compare
nornagon
approved these changes
Feb 27, 2023
VerteDinde
approved these changes
Feb 27, 2023
MarshallOfSound
approved these changes
Feb 27, 2023
|
Release Notes Persisted
|
This was referenced Feb 28, 2023
|
I have automatically backported this PR to "24-x-y", please check out #37443 |
|
I have automatically backported this PR to "23-x-y", please check out #37444 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
trop
bot
added
merged/24-x-y
codebytere
added a commit
that referenced
this pull request
Sep 29, 2023
* fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
3 tasks
codebytere
added a commit
that referenced
this pull request
Oct 2, 2023
fix: `BroadcastChannel` initialization location (#37421) * fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
trop bot
added a commit
that referenced
this pull request
Oct 2, 2023
* fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop bot
added a commit
that referenced
this pull request
Oct 2, 2023
* fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
added a commit
that referenced
this pull request
Oct 2, 2023
fix: `BroadcastChannel` initialization location (#37421) * fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
added a commit
that referenced
this pull request
Oct 2, 2023
fix: `BroadcastChannel` initialization location (#37421) * fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
fix: `BroadcastChannel` initialization location (electron#37421) * fix: BroadcastChannel initialization location * chore: update patches --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37417.
Refs nodejs/node#40532.
Fixes a bug wherein
BroadcastChannelshould have been initialized inlib/internal/bootstrap/browser.jsinstead oflib/internal/bootstrap/node.js. That inadvertently made it such that there was incorrect handling of the DOM vs Node.js implementations ofBroadcastChannel.Tested with https://gist.github.com/dfahlander/cb9dfccd6e32101843800feade72049c
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
BroadcastChanneldid not work correctly whencontextIsolation: false.