Tune ScaNN for other angular datasets #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! FYI nytimes-256 has a few "missing" vectors (all elements set to zero) which I guess is a bug or a feature depending on how you look at it (I've been arguing that's a common case that libraries should ideally be able to handle). So that might cause issues for ScANN |
|
Let me know if you want me to merge this. Otherwise will keep it open so you can optimize more :) |
|
Sure, please merge, thanks!
…On Thu, Jul 16, 2020 at 5:24 PM Erik Bernhardsson ***@***.***> wrote:
Let me know if you want me to merge this. Otherwise will keep it open so
you can optimize more :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUTQLN3OE7TVBQOA3NHSOLR35V2NANCNFSM4O42CRGA>
.
|
Closed
erikbern
added a commit
that referenced
this pull request
Apr 14, 2023
Tune ScaNN for other angular datasets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The originally submitted configuration was only tuned for Glove-100. Here are some better configurations for the other angular datasets. Still investigating NYTimes...
Glove-25:
LastFM: