KEMBAR78
Comparing f6a48828...2bcbf254 · facebook/react · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f6a48828
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2bcbf254
Choose a head ref
  • 5 commits
  • 12 files changed
  • 3 contributors

Commits on Oct 20, 2025

  1. [DevTools] BuiltInCallSite should have padding-left (#34922) 

    We don't normally show this but when we do, it should have the same
padding as other callsites.

<img width="313" height="241" alt="Screenshot 2025-10-19 at 10 46 22 PM"
src="https://github.com/user-attachments/assets/7f72149e-d748-4b71-8291-889038d676e7"
/>
    @sebmarkbage
    sebmarkbage authored Oct 20, 2025
    Configuration menu
    Copy the full SHA
    1440f4f View commit details
    Browse the repository at this point in the history

  2. Lower case "rsc stream" debug info (#34921) 

    This is an aesthetic thing. Most simple I/O entries are things like
"script", "stylesheet", "fetch" etc. which are all a single word and
lower case. The "RSC stream" name sticks out and draws unnecessary
attention to itself where as it's really the least interesting to look
at.

I don't love the name because I'm not sure how to explain it. It's
really mainly the byte size of the payload itself without considering
things like server awaits things which will have their own cause. So I'm
trying to communicate the download size of the stream of downloading the
`.rsc` file or the `"rsc stream"`.
    @sebmarkbage
    sebmarkbage authored Oct 20, 2025
    Configuration menu
    Copy the full SHA
    21272a6 View commit details
    Browse the repository at this point in the history

  3. [DevTools] fix: dont ship source maps for css in prod builds (#34913) 

    This has been causing some issues with the submission review on Firefox
store: we use OS-level paths in these source maps, which makes the build
artifact different from the one that's been submitted.

Also saves ~100Kb for main.js artifact.
    @hoxyq
    hoxyq authored Oct 20, 2025
    Configuration menu
    Copy the full SHA
    02c80f0 View commit details
    Browse the repository at this point in the history

  4. [DevTools] chore: read from build/COMMIT_SHA fle as fallback for comm… 

    …it hash (#34915)

This eliminates the gap in a reproducer for the React DevTools browser
extension from the source code that we submit to Firefox extension
stores.

We use the commit hash as part of the Backend version, here:

https://github.com/facebook/react/blob/2cfb221937eac48209d01d5dda5664de473b1953/packages/react-devtools-extensions/utils.js#L26-L38

The problem is that we archive the source code for Mozilla extension
store reviews and there is no git. But since we still download the React
sources from the CI, we could reuse the hash from `build/COMMIT_HASH`
file.
    @hoxyq
    hoxyq authored Oct 20, 2025
    Configuration menu
    Copy the full SHA
    aaad0ea View commit details
    Browse the repository at this point in the history

  5. [compiler] Fix false positive for useMemo reassigning context vars (#… 

    …34904)

Within a function expression local variables may use StoreContext for
local context variables, so the reassignment check here was firing too
often. We should only report an error for variables that are declared
outside the function, ie part of its `context`.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34904).
* #34903
* __->__ #34904
    @josephsavona
    josephsavona authored Oct 20, 2025
    Configuration menu
    Copy the full SHA
    2bcbf25 View commit details
    Browse the repository at this point in the history
Loading